This is an archive of the discontinued Mercurial Phabricator instance.

tests: make python oneliner portable to python 3 in remotefilelog test
ClosedPublic

Authored by durin42 on Jan 16 2019, 11:16 AM.

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

Summary

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

It's weird that print works as a function too in Python 2.

In D5602#82808, @pulkit wrote:

It's weird that print works as a function too in Python 2.

It's a hack: in the case of print(one_item) the parens are a noop on Python 2 and a function call on Python 3.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/test-remotefilelog-http.t (2 lines)

Commit	Parents	Author	Summary	Date
		Augie Fackler		Jan 16 2019, 10:58 AM

Status	Author	Revision
Closed	durin42	D5609 remotefilelog: fix some bytes/str portability issues for Python 3
Closed	durin42	D5608 shallowutil: fsdecode the bytes group name before passing to os
Closed	durin42	D5607 shallowutil: slice off a byte instead of subscripting
Closed	durin42	D5606 remotefilelog: check against bytes type instead of buffer and coerce to bytes
Closed	durin42	D5605 remotefilelog: use list comprehension instead of filter for py3 portability
Closed	durin42	D5604 tests: fix up uses of xrange in remotefilelog tests for py3
Closed	durin42	D5603 tests: add missing b prefixes in remotefilelog-getflogheads.py
Closed	durin42	D5602 tests: make python oneliner portable to python 3 in remotefilelog test
Closed	durin42	D5601 remotefilelog: implement __bool__ as well as __nonzero__ for py3
Closed	durin42	D5600 remotefilelog: fix logging in retry decorator
Closed	durin42	D5599 remotefilelog: import Queue on Python 2, and queue on Python 3
Closed	durin42	D5598 basepack: avoid 'rbe' mode in Python 3
Closed	durin42	D5597 remotefilelog: do file IO in terms of bytes

	> EOF			> EOF
	$ echo x > x			$ echo x > x
	$ echo y > y			$ echo y > y
	$ hg commit -qAm x			$ hg commit -qAm x
	$ hg serve -p $HGPORT -d --pid-file=../hg1.pid -E ../error.log -A ../access.log			$ hg serve -p $HGPORT -d --pid-file=../hg1.pid -E ../error.log -A ../access.log

	Build a query string for later use:			Build a query string for later use:
	$ GET=`hg debugdata -m 0 \| $PYTHON -c \			$ GET=`hg debugdata -m 0 \| $PYTHON -c \
	> 'import sys ; print [("?cmd=x_rfl_getfile&file=%s&node=%s" % tuple(s.split("\0"))) for s in sys.stdin.read().splitlines()][0]'`			> 'import sys ; print([("?cmd=x_rfl_getfile&file=%s&node=%s" % tuple(s.split("\0"))) for s in sys.stdin.read().splitlines()][0])'`

	$ cd ..			$ cd ..
	$ cat hg1.pid >> $DAEMON_PIDS			$ cat hg1.pid >> $DAEMON_PIDS

	$ hgcloneshallow http://localhost:$HGPORT/ shallow -q			$ hgcloneshallow http://localhost:$HGPORT/ shallow -q
	2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob)			2 files fetched over 1 fetches - (2 misses, 0.00% hit ratio) over *s (glob)

	$ grep getfile access.log			$ grep getfile access.log