This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5690

py3: use regular expression to deal with ENOENT formatting change
AbandonedPublic

Authored by durin42 on Jan 24 2019, 3:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

Yes, really.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jan 24 2019, 3:57 PM
durin42 updated this revision to Diff 13433.Jan 24 2019, 3:58 PM
yuja added a subscriber: yuja.Jan 25 2019, 5:15 AM
$ hg log -b --cwd=inexistent default
  • abort: $ENOENT$: 'inexistent'

+ abort: \$ENOENT\$: ('inexistent'|inexistent) (re)

That's our fault. The exception is caught as IOError on Python 3, and our
formatting of IOError and OSError are slightly different!

Maybe we should unify them.

durin42 abandoned this revision.Jan 30 2019, 5:16 PM

Revision Contents
Changeset List

PathPackages
Mcontrib/python3-whitelist (1 line)
Mtests/test-dispatch.t (4 lines)

Diff 13433

contrib/python3-whitelist

test-diffdir.t test-diffdir.t
test-diffstat.t test-diffstat.t
test-directaccess.t test-directaccess.t
test-dirstate-backup.t test-dirstate-backup.t
test-dirstate-nonnormalset.t test-dirstate-nonnormalset.t
test-dirstate-race.t test-dirstate-race.t
test-dirstate.t test-dirstate.t
test-dispatch.py test-dispatch.py
test-dispatch.t
test-doctest.py test-doctest.py
test-double-merge.t test-double-merge.t
test-drawdag.t test-drawdag.t
test-duplicateoptions.py test-duplicateoptions.py
test-editor-filename.t test-editor-filename.t
test-empty-dir.t test-empty-dir.t
test-empty-file.t test-empty-file.t
test-empty-group.t test-empty-group.t

tests/test-dispatch.t

$ mkdir -p badrepo/.hg $ mkdir -p badrepo/.hg
$ echo 'invalid-syntax' > badrepo/.hg/hgrc $ echo 'invalid-syntax' > badrepo/.hg/hgrc
$ hg log -b -Rbadrepo default $ hg log -b -Rbadrepo default
hg: parse error at badrepo/.hg/hgrc:1: invalid-syntax hg: parse error at badrepo/.hg/hgrc:1: invalid-syntax
[255] [255]
$ hg log -b --cwd=inexistent default $ hg log -b --cwd=inexistent default
abort: $ENOENT$: 'inexistent' abort: \$ENOENT\$: ('inexistent'|inexistent) (re)
[255] [255]
$ hg log -b '--config=ui.traceback=yes' 2>&1 | grep '^Traceback' $ hg log -b '--config=ui.traceback=yes' 2>&1 | grep '^Traceback'
Traceback (most recent call last): Traceback (most recent call last):
$ hg log -b '--config=profiling.enabled=yes' 2>&1 | grep -i sample $ hg log -b '--config=profiling.enabled=yes' 2>&1 | grep -i sample
Sample count: .*|No samples recorded\. (re) Sample count: .*|No samples recorded\. (re)
Early options can't be specified in [aliases] and [defaults] because they are Early options can't be specified in [aliases] and [defaults] because they are
[1] [1]
$ cd "$TESTTMP" $ cd "$TESTTMP"
OSError "No such file or directory" / "The system cannot find the path OSError "No such file or directory" / "The system cannot find the path
specified" should include filename even when it is empty specified" should include filename even when it is empty
$ hg -R a archive '' $ hg -R a archive ''
abort: $ENOENT$: '' abort: \$ENOENT\$(: '')? (re)
[255] [255]
#if no-outer-repo #if no-outer-repo
No repo: No repo:
$ hg cat $ hg cat
abort: no repository found in '$TESTTMP' (.hg not found)! abort: no repository found in '$TESTTMP' (.hg not found)!