This is an archive of the discontinued Mercurial Phabricator instance.

mail: document behavior of Python 3
ClosedPublic

Authored by indygreg on Jan 26 2019, 2:43 PM.

Details

Summary

test-notify.t (and possibly other tests) are failing on Python 3
because email.message.Message is now aware of encodings and
attempts to roundtrip values with the specified message encoding.

Python 2 doesn't perform this roundtripping. We have tests with
non-ascii data being serialized to a message that claims to use
ascii encoding.

I /think/ Mercurial's behavior may be buggy here. But I'm not
sure.

I'm documenting the behavior so the next person who looks into
this doesn't start from scratch like I did.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Jan 26 2019, 2:43 PM
pulkit accepted this revision.Jan 26 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.