Page MenuHomePhabricator

subrepo: bytes/str cleanups on Git support
ClosedPublic

Authored by durin42 on Jan 30 2019, 7:30 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jan 30 2019, 7:30 PM
durin42 updated this revision to Diff 13623.Jan 30 2019, 8:09 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Jan 31 2019, 7:55 AM
  • retdata = p.stdout.read().strip()

+ retdata = pycompat.fsencode(p.stdout.read().strip())

Curious why subprocess output can be a unicode. Is it a sort of text-mode
stream?

spectral updated this revision to Diff 15303.May 30 2019, 5:16 PM

Oops. A typo caused me to update this diff, please ignore that.