This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5822

configitems: use raw strings for hidden-{command,topic} items
ClosedPublic

Authored by indygreg on Feb 4 2019, 12:19 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHGb5642239fb32: configitems: use raw strings for hidden-{command,topic} items

Summary

These strings are regular expressions. The "\." needs to be
string escaped. We use raw strings to avoid doing that and the
SyntaxWarning we'd receive otherwise on Python 3.8.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 4 2019, 12:19 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFeb 4 2019, 12:19 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

Closed by commit rHGb5642239fb32: configitems: use raw strings for hidden-{command,topic} items (authored by indygreg). · Explain WhyFeb 4 2019, 6:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/configitems.py (4 lines)

Commit	Parents	Author	Summary	Date
		Gregory Szorc		Feb 4 2019, 12:13 PM

Status	Author	Revision
Closed	indygreg	D5822 configitems: use raw strings for hidden-{command,topic} items
Closed	indygreg	D5821 convert: use raw string for regular expressions
Closed	indygreg	D5820 graphmod: use raw string
Closed	indygreg	D5819 crecord: use raw string for regular expression
Closed	indygreg	D5818 patch: properly escape \ in string literals
Closed	indygreg	D5817 attr: make some docstrings raw strings
Closed	indygreg	D5816 global: make some docstrings raw strings
Closed	indygreg	D5815 global: use raw strings for regular expressions with escapes

Diff 13749

mercurial/configitems.py

	default=False,			default=False,
	)			)
	coreconfigitem('fsmonitor', 'warn_when_unused',			coreconfigitem('fsmonitor', 'warn_when_unused',
	default=True,			default=True,
	)			)
	coreconfigitem('fsmonitor', 'warn_update_file_count',			coreconfigitem('fsmonitor', 'warn_update_file_count',
	default=50000,			default=50000,
	)			)
	coreconfigitem('help', 'hidden-command\..*',			coreconfigitem('help', br'hidden-command\..*',
	default=False,			default=False,
	generic=True,			generic=True,
	)			)
	coreconfigitem('help', 'hidden-topic\..*',			coreconfigitem('help', br'hidden-topic\..*',
	default=False,			default=False,
	generic=True,			generic=True,
	)			)
	coreconfigitem('hooks', '.*',			coreconfigitem('hooks', '.*',
	default=dynamicdefault,			default=dynamicdefault,
	generic=True,			generic=True,
	)			)
	coreconfigitem('hgweb-paths', '.*',			coreconfigitem('hgweb-paths', '.*',

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	13749		Feb 4 2019, 12:19 PM	★	★
Diff 2	13782	rHGb5642239fb320072330c0fad7d232d718c6023b6	Feb 4 2019, 12:13 PM	★	★