diff: make --stat respect ui.relative-paths
ClosedPublic

Authored by martinvonz on Feb 8 2019, 3:30 AM.

Details

Summary

It would have been easy to make all diffs respect ui.relative-paths,
but we don't want that since it makes the diff invalid. Perhaps it
makes sense to do that with --noprefix since the point of that is to
make paths that are easy to copy&paste, and the diff is already
invalid anyway. But this patch just makes the --stat version respect
the config option. The --stat view is not even close to a valid diff,
so I think it makes sense to show the paths in more human-friendly
form.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped
martinvonz created this revision.Feb 8 2019, 3:30 AM
yuja added a subscriber: yuja.Feb 9 2019, 10:45 PM
It would have been easy to make all diffs respect ui.relative-paths,
but we don't want that since it makes the diff invalid. Perhaps it
makes sense to do that with --noprefix since the point of that is to
make paths that are easy to copy&paste, and the diff is already
invalid anyway. But this patch just makes the --stat version respect
the config option. The --stat view is not even close to a valid diff,
so I think it makes sense to show the paths in more human-friendly
form.

Seems fine, but I'm not sure about the Windows behavior:

  • Do we want to see backslash paths on Windows?
  • Backslash paths are parsed correctly?
In D5896#86559, @yuja wrote:
It would have been easy to make all diffs respect ui.relative-paths,
but we don't want that since it makes the diff invalid. Perhaps it
makes sense to do that with --noprefix since the point of that is to
make paths that are easy to copy&paste, and the diff is already
invalid anyway. But this patch just makes the --stat version respect
the config option. The --stat view is not even close to a valid diff,
so I think it makes sense to show the paths in more human-friendly
form.

Seems fine, but I'm not sure about the Windows behavior:

  • Do we want to see backslash paths on Windows?

I would assume that we want that.

  • Backslash paths are parsed correctly?

Good question! Some simple testing I just did suggests that it does work.

martinvonz updated this revision to Diff 14001.Feb 10 2019, 1:08 AM
This revision was automatically updated to reflect the committed changes.