debugignore: respect ui.relative-paths
ClosedPublic

Authored by martinvonz on Feb 8 2019, 12:45 PM.

Details

Summary

Not because I care about this, but I want to get rid of match.uipath()
and it's easier to respect the config than not.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped
martinvonz created this revision.Feb 8 2019, 12:45 PM
pulkit accepted this revision.Feb 9 2019, 4:44 PM
This revision was automatically updated to reflect the committed changes.

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1274/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

This seems to have converted a test from dos to unix style. I'm not sure if that was intentional, or if this feature is still a WIP. (Sorry, I've been busy lately, and haven't had time to follow this closely)

https://buildbot.mercurial-scm.org/builders/Win7%20x86_64%20hg%20tests/builds/1274/steps/run-tests.py%20%28python%202.7.13%29/logs/stdio

It wasn't intentional, and it took me a while to figure out why it changed, but I'm pretty confident it's just changed in the tests, since the test runner sets ui.slash. The old code called m.uipath() and that called util.pathto(). The new code calls repo.path(), which calls dirstate.pathto(), which also calls util.pathto(). However, if ui.slash is set, dirstate.pathto() also calls util.pconvert() to convert it back to a slash-separated path. Please send a patch to update the test case if you have access to a Windows machine.