This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5962

copies: add test that makes both the merging csets dirty and fails
ClosedPublic

Authored by khanchi97 on Feb 14 2019, 9:15 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGfc4b7a46fda1: copies: add test that makes both the merging csets dirty and fails
Summary

This patch is a part of series which is about the case when both the merging
csets are not descendant of merge base. The existing code assumes if c1 is
dirty there shouldn't be any partial copies from c2 i.e both2['incomplete']
and same for c2, if c2 is dirty both1['incomplete'] should be empty,
but this is not the right assumption.
Now as we know we can have both c1 and c2 dirty at the same time, it
is possible that c1 is dirty and both2['incomplete'] has some value.
Or if c2 is dirty and both1['incomplete'] has some value.

Added test shows that because of this assumption it could fail.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khanchi97 created this revision.Feb 14 2019, 9:15 AM
khanchi97 edited the summary of this revision. (Show Details)Feb 20 2019, 12:42 PM
khanchi97 added a comment.Feb 24 2019, 11:43 PM

Ping for review.

martinvonz added a subscriber: martinvonz.Feb 25 2019, 12:29 PM
martinvonz added inline comments.
tests/test-copytrace-heuristics.t
931–980 ↗(On Diff #14091)

nit: we usually redirect stderr and grep for the error (AssertionError here) to make it a bit shorter. (besides, the test here with /home/khanchi/ paths is clearly not going to pass on most people's machines)

khanchi97 updated this revision to Diff 14240.Feb 25 2019, 2:32 PM
khanchi97 added a comment.Feb 27 2019, 9:21 AM

@martinvonz updated this one too.

khanchi97 updated this revision to Diff 14309.Mar 3 2019, 1:50 AM
khanchi97 updated this revision to Diff 14347.Mar 4 2019, 2:52 PM
khanchi97 added a comment.Mar 8 2019, 11:58 PM

Ping for review.

martinvonz added inline comments.Mar 11 2019, 2:42 AM
tests/test-copies.t
575

As in the previous patch, I'd like to avoid hashes in the output by using hg l.

608

You can use -t :other here and not have to manually resolve it

khanchi97 updated this revision to Diff 14456.Mar 11 2019, 5:49 AM
khanchi97 marked 2 inline comments as done.Mar 11 2019, 5:51 AM

Thanks, I have updated the patch.

martinvonz accepted this revision.Mar 11 2019, 11:34 AM
This revision is now accepted and ready to land.Mar 11 2019, 11:34 AM
Closed by commit rHGfc4b7a46fda1: copies: add test that makes both the merging csets dirty and fails (authored by khanchi97). · Explain WhyMar 11 2019, 11:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-copies.t (79 lines)

Diff 14459

tests/test-copies.t

#testcases filelog compatibility #testcases filelog compatibility
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [extensions]
> rebase=
> [alias] > [alias]
> l = log -G -T '{rev} {desc}\n{files}\n' > l = log -G -T '{rev} {desc}\n{files}\n'
> EOF > EOF
#if compatibility #if compatibility
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [experimental] > [experimental]
> copies.read-from = compatibility > copies.read-from = compatibility
| b1 | b1
~ diff -r 5a4825cc2926 -r 94a2f1a0e8e2 b1 ~ diff -r 5a4825cc2926 -r 94a2f1a0e8e2 b1
--- a/b1 Thu Jan 01 00:00:00 1970 +0000 --- a/b1 Thu Jan 01 00:00:00 1970 +0000
+++ b/b1 Thu Jan 01 00:00:00 1970 +0000 +++ b/b1 Thu Jan 01 00:00:00 1970 +0000
@@ -1,1 +1,2 @@ @@ -1,1 +1,2 @@
b b
+baba +baba
Test which demonstrate that fullcopytracing algorithm can fail to handle a case when both the csets are dirty
----------------------------------------------------------------------------------------------------------
$ newrepo
$ echo a > a
$ hg add a
$ hg ci -m "added a"
$ echo b > b
$ hg add b
$ hg ci -m "added b"
$ echo foobar > willconflict
$ hg add willconflict
$ hg ci -m "added willconflict"
$ echo c > c
$ hg add c
$ hg ci -m "added c"
$ hg l
martinvonzUnsubmitted
Done

As in the previous patch, I'd like to avoid hashes in the output by using hg l.

martinvonz: As in the previous patch, I'd like to avoid hashes in the output by using `hg l`.
@ 3 added c
| c
o 2 added willconflict
| willconflict
o 1 added b
| b
o 0 added a
a
$ hg up ".^^"
0 files updated, 0 files merged, 2 files removed, 0 files unresolved
$ echo d > d
$ hg add d
$ hg ci -m "added d"
created new head
$ echo barfoo > willconflict
$ hg add willconflict
$ hg ci --amend -m "added willconflict and d"
$ hg l
@ 5 added willconflict and d
| d willconflict
| o 3 added c
| | c
| o 2 added willconflict
|/ willconflict
o 1 added b
| b
o 0 added a
a
$ hg rebase -r . -d 2 -t :other
martinvonzUnsubmitted
Done

You can use -t :other here and not have to manually resolve it

martinvonz: You can use `-t :other` here and not have to manually resolve it
rebasing 5:5018b1509e94 "added willconflict and d" (tip)
$ hg up 3 -q
$ hg l --hidden
o 6 added willconflict and d
| d willconflict
| x 5 added willconflict and d
| | d willconflict
| | x 4 added d
| |/ d
+---@ 3 added c
| | c
o | 2 added willconflict
|/ willconflict
o 1 added b
| b
o 0 added a
a
Now if we trigger a merge between cset revision 3 and 6 using base revision 4, in this case
both the merging csets will be dirty as no one is descendent of base revision:
$ hg graft -r 6 --base 4 --hidden 2>&1 | grep "AssertionError"
AssertionError