Page MenuHomePhabricator

copies: return True instead of filename as it is expected to return boolean
ClosedPublic

Authored by khanchi97 on Feb 14 2019, 9:16 AM.

Details

Summary

As the function documentation says this function should True if we hit
a match and False otherwise. And I see that we are not using that returned
filename anywhere.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khanchi97 created this revision.Feb 14 2019, 9:16 AM
martinvonz accepted this revision.Feb 19 2019, 1:10 AM
This revision is now accepted and ready to land.Feb 19 2019, 1:10 AM
This revision was automatically updated to reflect the committed changes.