context: use includematcher when checking dir/file conflicts
ClosedPublic

Authored by spectral on Thu, Feb 21, 10:16 PM.

Details

Summary

This is for performance; patternmatcher can't easily interpret its results to
make visitchildrenset be the "optimal" set of paths to inspect, but
includematcher can. Since there aren't any special patterns being used here, I
believe that the two matchers are equivalent.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
spectral created this revision.Thu, Feb 21, 10:16 PM
martinvonz accepted this revision.Fri, Feb 22, 12:47 AM
martinvonz added a subscriber: martinvonz.

I suppose includematcher can be optimized that way because it's always recursive? Perhaps it should have been called recursivematcher or something.

This revision is now accepted and ready to land.Fri, Feb 22, 12:47 AM
This revision was automatically updated to reflect the committed changes.