( )⚙ D5999 context: use includematcher when checking dir/file conflicts

This is an archive of the discontinued Mercurial Phabricator instance.

context: use includematcher when checking dir/file conflicts
ClosedPublic

Authored by spectral on Feb 21 2019, 10:16 PM.

Details

Summary

This is for performance; patternmatcher can't easily interpret its results to
make visitchildrenset be the "optimal" set of paths to inspect, but
includematcher can. Since there aren't any special patterns being used here, I
believe that the two matchers are equivalent.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Feb 21 2019, 10:16 PM
martinvonz accepted this revision.Feb 22 2019, 12:47 AM
martinvonz added a subscriber: martinvonz.

I suppose includematcher can be optimized that way because it's always recursive? Perhaps it should have been called recursivematcher or something.

This revision is now accepted and ready to land.Feb 22 2019, 12:47 AM
This revision was automatically updated to reflect the committed changes.