( )⚙ D6026 lock: Improve the waiting for lock message which will help newcomers (issue6081)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6026

lock: Improve the waiting for lock message which will help newcomers (issue6081)
Needs RevisionPublic

Authored by akshjain.jain74 on Feb 26 2019, 4:30 AM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Feb 26 2019, 9:21 AM

This patch does not changes any code. It only changes some test output. You need to change the error message in the code.

akshjain.jain74 added a comment.Feb 26 2019, 9:23 AM

Ya I am sending that just trying to find out the file

pulkit added inline comments.Feb 28 2019, 4:31 PM
hgext/journal.py
310

This is only for locking namejournal.lock and not for working directory lock and store lock. We need to improve message there too.

316

remove which file manually to continue?

I think we should delete the If it still fails, ..... remove the file manually to continue part.

tests/test-lock-badness.t
18

unrelated changes in the test file here and below.

akshjain.jain74 marked 2 inline comments as done.Feb 28 2019, 5:11 PM
akshjain.jain74 updated this revision to Diff 14279.
akshjain.jain74 marked an inline comment as done.Feb 28 2019, 5:14 PM

@pulkit done changes as per your suggestion in lock file too but what did you meant by storelock?

pulkit added a comment.Mar 6 2019, 8:40 AM

I am not sure the new message is much helpful. As JordiGH and others pointed out on IRC, it will definitely be helpful if we can show which operation has the lock right now.

Something like:

waiting for lock on working directory of b held by process '*' running <cmd-name> on host '*'

tests/test-extdiff.t
155 ↗(On Diff #14291)

unrelated changes.

tests/test-lock-badness.t
18

still here are unrealted changes.

62

The output is not correctly aligned.

akshjain.jain74 added a comment.Mar 6 2019, 12:31 PM

okay @pulkit let me work upon your suggestion and

tests/test-lock-badness.t
18

I accept these changes while running test, if i am not changing this then it will cause test failing

akshjain.jain74 added a comment.Mar 6 2019, 2:31 PM
In D6026#88552, @pulkit wrote:

I am not sure the new message is much helpful. As JordiGH and others pointed out on IRC, it will definitely be helpful if we can show which operation has the lock right now.
Something like:
waiting for lock on working directory of b held by process '*' running <cmd-name> on host '*'

So for which commands we can show this message, like i got message when i run hg commit --amend sometimes

marmoute added a subscriber: marmoute.Jan 23 2020, 12:12 PM

Gentle ping on this. This has been around for a long time, what's the status of it?

baymax requested changes to this revision.Apr 28 2020, 4:18 AM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Apr 28 2020, 4:18 AM

Revision Contents
Changeset List

PathPackages
Mhgext/journal.py (8 lines)
Mtests/test-lock-badness.t (5 lines)

Diff 14277

hgext/journal.py

"""Create a lock for the journal file""" """Create a lock for the journal file"""
if self._currentlock(self._lockref) is not None: if self._currentlock(self._lockref) is not None:
raise error.Abort(_('journal lock does not support nesting')) raise error.Abort(_('journal lock does not support nesting'))
desc = _('journal of %s') % vfs.base desc = _('journal of %s') % vfs.base
try: try:
l = lock.lock(vfs, 'namejournal.lock', 0, desc=desc) l = lock.lock(vfs, 'namejournal.lock', 0, desc=desc)
except error.LockHeld as inst: except error.LockHeld as inst:
self.ui.warn( self.ui.warn(
_("waiting for lock on %s held by %r\n") % (desc, inst.locker)) _("waiting for lock on %s held by %r\n" "on host %r\n"
pulkitUnsubmitted
Done

This is only for locking namejournal.lock and not for working directory lock and store lock. We need to improve message there too.

pulkit: This is only for locking namejournal.lock and not for working directory lock and store lock. We…
"""Another Mercurial process seems to be running in
this repository, e.g. an editor opened by 'hg commit'.
Please make sure all processes are terminated then
try again. If it still fails, a Mercurial process
may have crashed in this repository earlier:
remove the file manually to continue.\n""") % (desc, inst.locker))
pulkitUnsubmitted
Done

remove which file manually to continue?

I think we should delete the If it still fails, ..... remove the file manually to continue part.

pulkit: remove which file manually to continue? I think we should delete the `If it still fails, .....
# default to 600 seconds timeout # default to 600 seconds timeout
l = lock.lock( l = lock.lock(
vfs, 'namejournal.lock', vfs, 'namejournal.lock',
self.ui.configint("ui", "timeout"), desc=desc) self.ui.configint("ui", "timeout"), desc=desc)
self.ui.warn(_("got lock after %s seconds\n") % l.delay) self.ui.warn(_("got lock after %s seconds\n") % l.delay)
self._lockref = weakref.ref(l) self._lockref = weakref.ref(l)
return l return l

tests/test-lock-badness.t

$ hg clone a b $ hg clone a b
updating to branch default updating to branch default
1 files updated, 0 files merged, 0 files removed, 0 files unresolved 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
Test that raising an exception in the release function doesn't cause the lock to choke Test that raising an exception in the release function doesn't cause the lock to choke
$ cat > testlock.py << EOF $ cat > testlock.py << EOF
> from mercurial import error, registrar > from mercurial import error, registrar
>
pulkitUnsubmitted
Done

unrelated changes in the test file here and below.

pulkit: unrelated changes in the test file here and below.
pulkitUnsubmitted
Not Done

still here are unrealted changes.

pulkit: still here are unrealted changes.
akshjain.jain74AuthorUnsubmitted
Not Done

I accept these changes while running test, if i am not changing this then it will cause test failing

akshjain.jain74: I accept these changes while running test, if i am not changing this then it will cause test…
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
>
> def acquiretestlock(repo, releaseexc): > def acquiretestlock(repo, releaseexc):
> def unlock(): > def unlock():
> if releaseexc: > if releaseexc:
> raise error.Abort(b'expected release exception') > raise error.Abort(b'expected release exception')
> l = repo._lock(repo.vfs, b'testlock', False, unlock, None, b'test lock') > l = repo._lock(repo.vfs, b'testlock', False, unlock, None, b'test lock')
> return l > return l
>
> @command(b'testlockexc') > @command(b'testlockexc')
> def testlockexc(ui, repo): > def testlockexc(ui, repo):
> testlock = acquiretestlock(repo, True) > testlock = acquiretestlock(repo, True)
> try: > try:
> testlock.release() > testlock.release()
> finally: > finally:
> try: > try:
> testlock = acquiretestlock(repo, False) > testlock = acquiretestlock(repo, False)
$ echo b > b/b $ echo b > b/b
$ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout & $ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &
$ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \ $ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \
> > preup-stdout 2>preup-stderr > > preup-stdout 2>preup-stderr
$ wait $ wait
$ cat preup-stdout $ cat preup-stdout
$ cat preup-stderr $ cat preup-stderr
waiting for lock on working directory of b held by process '*' on host '*' (glob) waiting for lock on working directory of b held by process '*' on host '*' (glob)
got lock after * seconds (glob) got lock after * seconds (glob)
pulkitUnsubmitted
Not Done

The output is not correctly aligned.

pulkit: The output is not correctly aligned.
$ cat stdout $ cat stdout
adding b adding b
On processs waiting on another, warning after a long time. On processs waiting on another, warning after a long time.
$ echo b > b/c $ echo b > b/c
$ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout & $ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &
$ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \ $ hg -R b up -q --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \
> --config ui.timeout.warn=250 --debug\ > --config ui.timeout.warn=250 --debug\
> > preup-stdout 2>preup-stderr > > preup-stdout 2>preup-stderr
$ wait $ wait
$ cat preup-stdout $ cat preup-stdout
calling hook pre-update: hghook_pre-update.sleephalf calling hook pre-update: hghook_pre-update.sleephalf
waiting for lock on working directory of b held by process '*' on host '*' (glob) waiting for lock on working directory of b held by process '*' on host '*' (glob)
got lock after * seconds (glob) got lock after * seconds (glob)
0 files updated, 0 files merged, 0 files removed, 0 files unresolved 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ cat preup-stderr $ cat preup-stderr
$ cat stdout $ cat stdout
adding e adding e
On processs waiting on another, warning disabled, (debug output on) On processs waiting on another, warning disabled, (debug output on)
$ echo b > b/f $ echo b > b/f
$ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout & $ hg -R b ci -A -m b --config hooks.precommit="python:`pwd`/hooks.py:sleepone" > stdout &
$ hg -R b up --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \ $ hg -R b up --config hooks.pre-update="python:`pwd`/hooks.py:sleephalf" \
> --config ui.timeout.warn=-1 --debug\ > --config ui.timeout.warn=-1 --debug\
> > preup-stdout 2>preup-stderr > > preup-stdout 2>preup-stderr
$ wait $ wait
$ cat preup-stdout $ cat preup-stdout
calling hook pre-update: hghook_pre-update.sleephalf calling hook pre-update: hghook_pre-update.sleephalf
waiting for lock on working directory of b held by process '*' on host '*' (glob) waiting for lock on working directory of b held by process '*' on host '*' (glob)
got lock after * seconds (glob) got lock after * seconds (glob)
0 files updated, 0 files merged, 0 files removed, 0 files unresolved 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ cat preup-stderr $ cat preup-stderr
$ cat stdout $ cat stdout
adding f adding f
Pushing to a local read-only repo that can't be locked Pushing to a local read-only repo that can't be locked
$ chmod 100 a/.hg/store $ chmod 100 a/.hg/store
$ hg -R b push a $ hg -R b push a
pushing to a pushing to a
searching for changes searching for changes
abort: could not lock repository a: Permission denied abort: could not lock repository a: Permission denied
[255] [255]
$ chmod 700 a/.hg/store $ chmod 700 a/.hg/store