This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6041

py3: pass a str to getpass.getpass()
ClosedPublic

Authored by pulkit on Mar 1 2019, 7:13 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8e364664a999: py3: pass a str to getpass.getpass()
Summary

Otherwise I see password: b'' on the prompt.

  1. skip-blame because just prefix

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Mar 1 2019, 7:13 PM
Closed by commit rHG8e364664a999: py3: pass a str to getpass.getpass() (authored by pulkit). · Explain WhyMar 1 2019, 9:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (2 lines)

Diff 14288

mercurial/ui.py

# to interact with tty even if fin is not a tty. # to interact with tty even if fin is not a tty.
with self.timeblockedsection('stdio'): with self.timeblockedsection('stdio'):
if self.configbool('ui', 'nontty'): if self.configbool('ui', 'nontty'):
l = self._fin.readline() l = self._fin.readline()
if not l: if not l:
raise EOFError raise EOFError
return l.rstrip('\n') return l.rstrip('\n')
else: else:
return getpass.getpass('') return getpass.getpass(r'')
except EOFError: except EOFError:
raise error.ResponseExpected() raise error.ResponseExpected()
def status(self, *msg, **opts): def status(self, *msg, **opts):
'''write status message to output (if ui.quiet is False) '''write status message to output (if ui.quiet is False)
This adds an output label of "ui.status". This adds an output label of "ui.status".
''' '''