Page MenuHomePhabricator

directaccess: store the access level in the ui object in dispatch
AbandonedPublic

Authored by pulkit on Sep 2 2017, 1:39 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Summary

This will help us to look for the level whenever we need that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Sep 2 2017, 1:39 PM
quark requested changes to this revision.Sep 7 2017, 2:00 AM
quark added a subscriber: quark.

Setting ui config seems like an abuse of the config system. I think it'll be cleaner if feed the right "repo" object directly to the command function. i.e. By default commands get the "visible" repo: repo.filtered('visible') - see hg.repository. We can change that and add special filter - like repo.fitlered('visible-directaccess-warn'). So the repo object carries the information itself.

This revision now requires changes to proceed.Sep 7 2017, 2:00 AM
durham added a subscriber: durham.Sep 7 2017, 8:52 PM
durham added inline comments.
tests/test-basic.t
4

Any idea why the order changed? Same for below

pulkit abandoned this revision.Sep 13 2017, 2:57 PM