This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6176

revset: remove comment about linkrev workaround from user-facing docs
ClosedPublic

Authored by martinvonz on Mar 31 2019, 12:43 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGcab19d49f8bd: revset: remove comment about linkrev workaround from user-facing docs
Summary

I think the code is clear enough so we don't need to keep the comment
at all (by now, most Mercurial developers are probably familiar with
the linkrevs issues).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Mar 31 2019, 12:43 PM
pulkit accepted this revision.Mar 31 2019, 4:24 PM
Closed by commit rHGcab19d49f8bd: revset: remove comment about linkrev workaround from user-facing docs (authored by martinvonz). · Explain WhyMar 31 2019, 4:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (3 lines)

Diff 14610

mercurial/revset.py

For performance reasons, visits only revisions mentioned in the file-level For performance reasons, visits only revisions mentioned in the file-level
filelog, rather than filtering through all changesets (much faster, but filelog, rather than filtering through all changesets (much faster, but
doesn't include deletes or duplicate changes). For a slower, more accurate doesn't include deletes or duplicate changes). For a slower, more accurate
result, use ``file()``. result, use ``file()``.
The pattern without explicit kind like ``glob:`` is expected to be The pattern without explicit kind like ``glob:`` is expected to be
relative to the current directory and match against a file exactly relative to the current directory and match against a file exactly
for efficiency. for efficiency.
If some linkrev points to revisions filtered by the current repoview, we'll
work around it to return a non-filtered value.
""" """
# i18n: "filelog" is a keyword # i18n: "filelog" is a keyword
pat = getstring(x, _("filelog requires a pattern")) pat = getstring(x, _("filelog requires a pattern"))
s = set() s = set()
cl = repo.changelog cl = repo.changelog
if not matchmod.patkind(pat): if not matchmod.patkind(pat):