This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6206

branchmap: implement __contains__()
ClosedPublic

Authored by pulkit on Apr 5 2019, 9:31 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf0def07fa82f: branchmap: implement __contains__()
Summary

We have good occurences of if branch in branchmap() in our code. If
contains() is not implemented then it will use iter() to find whether
the element exists or not which is not good.

I am bit confused that whether I should move existing callers to hasbranch() or
this patch is a good way.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Apr 5 2019, 9:31 AM
Closed by commit rHGf0def07fa82f: branchmap: implement __contains__() (authored by pulkit). · Explain WhyApr 12 2019, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (3 lines)

Diff 14726

mercurial/branchmap.py

return iter(self._entries) return iter(self._entries)
def __setitem__(self, key, value): def __setitem__(self, key, value):
self._entries[key] = value self._entries[key] = value
def __getitem__(self, key): def __getitem__(self, key):
return self._entries[key] return self._entries[key]
def __contains__(self, key):
return key in self._entries
def iteritems(self): def iteritems(self):
return self._entries.iteritems() return self._entries.iteritems()
def hasbranch(self, label): def hasbranch(self, label):
""" checks whether a branch of this name exists or not """ """ checks whether a branch of this name exists or not """
return label in self._entries return label in self._entries
@classmethod @classmethod