This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6238

branchcache: don't verify while creating a copy
ClosedPublic

Authored by pulkit on Apr 16 2019, 8:26 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb26455ffa7fa: branchcache: don't verify while creating a copy
Summary

The copy will not be mark as verified, so there is no need to verify nodes.
Thanks to Yuya who spotted this while reviewing.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Apr 16 2019, 8:26 AM
Closed by commit rHGb26455ffa7fa: branchcache: don't verify while creating a copy (authored by pulkit). · Explain WhyApr 16 2019, 10:54 AM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Apr 16 2019, 7:08 PM
def copy(self):
    """return an deep copy of the branchcache object"""
  • self._verifyall() return type(self)( self._entries, self.tipnode, self.tiprev, self.filteredhash, self._closednodes)

Looks good, but it's probably better to copy the verification state to
new instance, or simply make branchcache() start with "verified" state.
IIUC, only branches loaded from file have to be validated.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (1 line)

Diff 14761

mercurial/branchmap.py

def iterheads(self): def iterheads(self):
""" returns all the heads """ """ returns all the heads """
self._verifyall() self._verifyall()
return self._entries.itervalues() return self._entries.itervalues()
def copy(self): def copy(self):
"""return an deep copy of the branchcache object""" """return an deep copy of the branchcache object"""
self._verifyall()
return type(self)( return type(self)(
self._entries, self.tipnode, self.tiprev, self.filteredhash, self._entries, self.tipnode, self.tiprev, self.filteredhash,
self._closednodes) self._closednodes)
def write(self, repo): def write(self, repo):
try: try:
f = repo.cachevfs(self._filename(repo), "w", atomictemp=True) f = repo.cachevfs(self._filename(repo), "w", atomictemp=True)
cachekey = [hex(self.tipnode), '%d' % self.tiprev] cachekey = [hex(self.tipnode), '%d' % self.tiprev]