This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6236

branchcache: lazily validate nodes in iteritems()
ClosedPublic

Authored by pulkit on Apr 15 2019, 12:26 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf0203c3406e7: branchcache: lazily validate nodes in iteritems()
Summary

This saves ~0.30 sec on creating a new branch on our internal repo.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (5 lines)

Diff 14763

mercurial/branchmap.py

self._verifybranch(key) self._verifybranch(key)
return self._entries[key] return self._entries[key]
def __contains__(self, key): def __contains__(self, key):
self._verifybranch(key) self._verifybranch(key)
return key in self._entries return key in self._entries
def iteritems(self): def iteritems(self):
self._verifyall() for k, v in self._entries.iteritems():
return self._entries.iteritems() self._verifybranch(k)
yield k, v
def hasbranch(self, label): def hasbranch(self, label):
""" checks whether a branch of this name exists or not """ """ checks whether a branch of this name exists or not """
self._verifybranch(label) self._verifybranch(label)
return label in self._entries return label in self._entries
@classmethod @classmethod
def fromfile(cls, repo): def fromfile(cls, repo):