Page MenuHomePhabricator

discovery: new devel.discovery.randomize option
AbandonedPublic

Authored by gracinet on May 6 2019, 11:30 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

By default, this is True, but setting it to False is a uniform
way to kill all randomness in integration tests such as test-setdiscovery.t

By "uniform" we mean that it can be passed to implementations in other
languages, for which the monkey-patching of random.sample would be
irrelevant.

In the above mentioned test file, we use it right away,
replacing the adhoc extension that had the same purpose, and to derandomize a
case with many round-trips, that we'll need to behave uniformly in the Rust
version.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

gracinet created this revision.May 6 2019, 11:30 AM
gracinet abandoned this revision.

I'm abandoning this revision because I have to resubmit the whole series after partial incorrect application last week and subsequent droping from the actual repo.

@kevincox, that's the last one. I'll try and make it explicit to you in the new series what's new and what's unchanged