Page MenuHomePhabricator

histedit: remove transaction from state object
ClosedPublic

Authored by martinvonz on Jul 12 2017, 5:38 PM.

Details

Summary

The transaction is only used within a single function, so no need to
store it on the state object.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jul 12 2017, 5:38 PM
phillco accepted this revision.Jul 12 2017, 7:12 PM
dsp accepted this revision.Jul 12 2017, 7:55 PM
dsp added a subscriber: dsp.
dsp added inline comments.
hgext/histedit.py
283

I think you can also remove this. I don't see it anywhere used.

martinvonz marked an inline comment as done.Jul 12 2017, 7:58 PM
martinvonz updated this revision to Diff 98.
martinvonz added inline comments.Jul 12 2017, 7:58 PM
hgext/histedit.py
283

I thought I did, but apparently not.

dsp accepted this revision.Jul 13 2017, 11:16 AM
durham accepted this revision.Jul 13 2017, 3:53 PM
This revision was automatically updated to reflect the committed changes.