This is an archive of the discontinued Mercurial Phabricator instance.
Authored by
khanchi97 on Jun 7 2019, 9:55 AM.
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. | |
- Unit
Automatic diff as part of commit; unit tests not applicable. | |
Event Timeline
This revision now requires changes to proceed.
khanchi97 retitled this revision from
branch: add --force flag to close branch from a not-head changeset to
commit: add --force flag to close branch from a non-head changeset.
khanchi97 retitled this revision from
commit: add --force flag to close branch from a non-head changeset to
commit: add --force-close-branch flag to close a non-head changeset.
pulkit accepted this revision.
This revision is now accepted and ready to land.
This revision was automatically updated to reflect the committed changes.
I didn't realize that --force wasn't already an option for commit, because it is an option to internal commit functions. I still like this idea, but maybe you need to remove this from opts after completing the check here (and also in the --no-close-branch case). Otherwise, it risks bypassing existing safeguards.
https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/localrepo.py#l2498
(I have no idea why that's allowed at all. MQ maybe?)