Page MenuHomePhabricator

phabricator: add commenting to phabsend for new/updated Diffs
ClosedPublic

Authored by Kwan on Fri, Jun 7, 5:18 PM.

Details

Summary

Especially useful when sending updates to existing Revisions so one can specify
the sort of changes e.g. "Address review comments" or "Rebase to tip"

If the diff content hasn't changed then it only needs a metadata update which
doesn't show in the Phabricator updates UI, so don't add a comment that will.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Fri, Jun 7, 5:18 PM

While the .t test can't directly show this, now that we have a VCR matcher for the body we can test the output. In action: https://phabricator-dev.allizom.org/D1253

Kwan updated this revision to Diff 15374.Fri, Jun 7, 5:24 PM

Doctor repo name in the recordings that I'd missed before

Alphare added a subscriber: Alphare.Sat, Jun 8, 6:57 AM

@Kwan Very useful, thanks!

pulkit accepted this revision.Sat, Jun 8, 12:08 PM
This revision was automatically updated to reflect the committed changes.