( )⚙ D6499 phabricator: make `hg debugcallconduit` work outside a hg repo

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6499

phabricator: make `hg debugcallconduit` work outside a hg repo
ClosedPublic

Authored by pulkit on Jun 8 2019, 12:07 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG16312ea45a8b: phabricator: make `hg debugcallconduit` work outside a hg repo
Summary

I am trying to write some automations around phabricator and having
debugcallconduit work outside a hg repo will be nice!

Marking command as optionalrepo instead of norepo because we might to load
repo/.hg/hgrc.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jun 8 2019, 12:07 PM
yuja added a subscriber: yuja.Jun 8 2019, 9:51 PM

-@vcrcommand(b'debugcallconduit', [], _(b'METHOD'))
-def debugcallconduit(ui, repo, name):
+@vcrcommand(b'debugcallconduit', [], _(b'METHOD'), norepo=True)
+def debugcallconduit(ui, name):

Maybe optionalrepo to load repo/.hg/hgrc?

pulkit edited the summary of this revision. (Show Details)Jun 9 2019, 7:56 PM
pulkit updated this revision to Diff 15410.
Closed by commit rHG16312ea45a8b: phabricator: make `hg debugcallconduit` work outside a hg repo (authored by pulkit). · Explain WhyJun 10 2019, 9:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (7 lines)

Diff 15411

hgext/phabricator.py

_VCR_FLAGS = [ _VCR_FLAGS = [
(b'', b'test-vcr', b'', (b'', b'test-vcr', b'',
_(b'Path to a vcr file. If nonexistent, will record a new vcr transcript' _(b'Path to a vcr file. If nonexistent, will record a new vcr transcript'
b', otherwise will mock all http requests using the specified vcr file.' b', otherwise will mock all http requests using the specified vcr file.'
b' (ADVANCED)' b' (ADVANCED)'
)), )),
] ]
def vcrcommand(name, flags, spec, helpcategory=None): def vcrcommand(name, flags, spec, helpcategory=None, optionalrepo=False):
fullflags = flags + _VCR_FLAGS fullflags = flags + _VCR_FLAGS
def hgmatcher(r1, r2): def hgmatcher(r1, r2):
if r1.uri != r2.uri or r1.method != r2.method: if r1.uri != r2.uri or r1.method != r2.method:
return False return False
r1params = r1.body.split(b'&') r1params = r1.body.split(b'&')
r2params = r2.body.split(b'&') r2params = r2.body.split(b'&')
return set(r1params) == set(r2params) return set(r1params) == set(r2params)
stubs.VCRHTTPSConnection), stubs.VCRHTTPSConnection),
]) ])
vcr.register_matcher(r'hgmatcher', hgmatcher) vcr.register_matcher(r'hgmatcher', hgmatcher)
with vcr.use_cassette(cassette, match_on=[r'hgmatcher']): with vcr.use_cassette(cassette, match_on=[r'hgmatcher']):
return fn(*args, **kwargs) return fn(*args, **kwargs)
return fn(*args, **kwargs) return fn(*args, **kwargs)
inner.__name__ = fn.__name__ inner.__name__ = fn.__name__
inner.__doc__ = fn.__doc__ inner.__doc__ = fn.__doc__
return command(name, fullflags, spec, helpcategory=helpcategory)(inner) return command(name, fullflags, spec, helpcategory=helpcategory,
optionalrepo=optionalrepo)(inner)
return decorate return decorate
def urlencodenested(params): def urlencodenested(params):
"""like urlencode, but works with nested parameters. """like urlencode, but works with nested parameters.
For example, if params is {'a': ['b', 'c'], 'd': {'e': 'f'}}, it will be For example, if params is {'a': ['b', 'c'], 'd': {'e': 'f'}}, it will be
flattened to {'a[0]': 'b', 'a[1]': 'c', 'd[e]': 'f'} and then passed to flattened to {'a[0]': 'b', 'a[1]': 'c', 'd[e]': 'f'} and then passed to
urlencode. Note: the encoding is consistent with PHP's http_build_query. urlencode. Note: the encoding is consistent with PHP's http_build_query.
json.loads(body) json.loads(body)
) )
if parsed.get(b'error_code'): if parsed.get(b'error_code'):
msg = (_(b'Conduit Error (%s): %s') msg = (_(b'Conduit Error (%s): %s')
% (parsed[b'error_code'], parsed[b'error_info'])) % (parsed[b'error_code'], parsed[b'error_info']))
raise error.Abort(msg) raise error.Abort(msg)
return parsed[b'result'] return parsed[b'result']
@vcrcommand(b'debugcallconduit', [], _(b'METHOD')) @vcrcommand(b'debugcallconduit', [], _(b'METHOD'), optionalrepo=True)
def debugcallconduit(ui, repo, name): def debugcallconduit(ui, repo, name):
"""call Conduit API """call Conduit API
Call parameters are read from stdin as a JSON blob. Result will be written Call parameters are read from stdin as a JSON blob. Result will be written
to stdout as a JSON blob. to stdout as a JSON blob.
""" """
# json.loads only accepts bytes from 3.6+ # json.loads only accepts bytes from 3.6+
rawparams = encoding.unifromlocal(ui.fin.read()) rawparams = encoding.unifromlocal(ui.fin.read())