Page MenuHomePhabricator

py3: hack around inconsistency of type of name passed to DNSQuestion
ClosedPublic

Authored by pulkit on Jun 11 2019, 2:00 PM.

Details

Summary

I don't like this patch but this is the easiest way I could fix it. There are
some callers which pass name which is bytes, some pass name which is str. I just
encode() that if that's str.

This does makes test-paths.t pass, but I am not confident whether the whole of
zeroconf will work on py3 or not.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jun 11 2019, 2:00 PM

Review ping for this stack.

pulkit updated this revision to Diff 15711.Jun 29 2019, 7:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.