Page MenuHomePhabricator

relnotes: added description about statemod._statecheck
ClosedPublic

Authored by taapas1128 on Jun 20 2019, 2:56 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

taapas1128 created this revision.Jun 20 2019, 2:56 PM
martinvonz added inline comments.
relnotes/next
66–72

The "private" (underscore-prefixed) members should not be mentioned here. Extension developers should not be accessing them, so they don't need to know about them. What they need to know is that if they had been adding operations to cmdutil.unfinishedstates, cmdutil.afterresolvestates, or cmdutil.STATES before, they now need to use state.addunfinished().

I now see that state.addunfinished() has **kwargs, which means they will have to look at the _statecheck class after all. Perhaps we should copy the arguments over from the class to the function (and remove the defaults from the class) so it's easier to find them?

taapas1128 added inline comments.Jun 27 2019, 3:24 PM
relnotes/next
66–72

@martinvonz But that would destroy the integrity of statecheck class and addunfinished is just below statecheck class so one can easily look at statecheck if definitions for various flags are to be known. Still if you want I can do that.

taapas1128 updated this revision to Diff 15690.Jun 27 2019, 6:02 PM
taapas1128 marked an inline comment as done.Jun 27 2019, 6:03 PM
martinvonz accepted this revision.Jun 27 2019, 6:06 PM
martinvonz added inline comments.
relnotes/next
68–69

I'll drop the last sentence in flight since D6583 has landed.

This revision is now accepted and ready to land.Jun 27 2019, 6:06 PM
taapas1128 added inline comments.Jun 27 2019, 6:08 PM
relnotes/next
68–69

thanks!