This is an archive of the discontinued Mercurial Phabricator instance.

relnotes/next
63–69	The "private" (underscore-prefixed) members should not be mentioned here. Extension developers should not be accessing them, so they don't need to know about them. What they need to know is that if they had been adding operations to `cmdutil.unfinishedstates`, `cmdutil.afterresolvestates`, or `cmdutil.STATES` before, they now need to use `state.addunfinished()`. I now see that `state.addunfinished()` has `**kwargs`, which means they will have to look at the `_statecheck` class after all. Perhaps we should copy the arguments over from the class to the function (and remove the defaults from the class) so it's easier to find them?

relnotes/next
63–69	@martinvonz But that would destroy the integrity of `statecheck` class and `addunfinished` is just below `statecheck` class so one can easily look at `statecheck` if definitions for various flags are to be known. Still if you want I can do that.

taapas1128 marked an inline comment as done.Jun 27 2019, 6:03 PM

martinvonz added inline comments.

relnotes/next
65–66	I'll drop the last sentence in flight since D6583 has landed.

This revision is now accepted and ready to land.Jun 27 2019, 6:06 PM

This revision was automatically updated to reflect the committed changes.

relnotes/next
65–66	thanks!

Revision Contents
Changeset List

			Path	Packages
M			relnotes/next (12 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	15620		Jun 20 2019, 2:56 PM	★	★
Diff 2	15690		Jun 27 2019, 6:02 PM	★	★
Diff 3	15691	rHGdf5f674050b738c47f16525f9b899410cbdb0925	Jun 20 2019, 2:56 PM	★	★

Commit	Parents	Author	Summary	Date
665503eddb1c	ed8aed949b2e	Taapas Agrawal		Jun 20 2019, 2:56 PM

Status	Author	Revision
Closed	taapas1128	D6557 relnotes: added description about statemod._statecheck
Closed	taapas1128	D6551 statecheck: added support for cmdutil.afterresolvedstates
Closed	taapas1128	D6548 mq: fix for merge detection methods
Closed	taapas1128	D6547 shelve: removed redundant merge detection method
Closed	taapas1128	D6503 statecheck: added support for STATES
Closed	taapas1128	D6502 state: moved cmdutil.STATES and utilities to state.py
Closed	taapas1128	D6501 state: created new class statecheck to handle unfinishedstates
Closed	taapas1128	D6484 states: moved cmdutil.unfinishedstates to state.py


	* Matchers are no longer iterable. Use `match.files()` instead.			* Matchers are no longer iterable. Use `match.files()` instead.

	* `match.visitdir()` and `match.visitchildrenset()` now expect the			* `match.visitdir()` and `match.visitchildrenset()` now expect the
	empty string instead of '.' to indicate the root directory.			empty string instead of '.' to indicate the root directory.

	* `util.dirs()` and `util.finddirs()` now include an entry for the			* `util.dirs()` and `util.finddirs()` now include an entry for the
	root directory (empty string).			root directory (empty string).

				* New API to manage unfinished operations: Earlier there were distinct APIs
				which dealt with unfinished states and separate lists maintaining them
				that are `cmdutil.afterresolvestates`, `cmdutil.unfinishedstates` and
				`cmdutil.STATES`. Now these have been unified to a single
				API which handles the various states and their utilities. This API
				has been added to `state.py`. Now instead of adding to these 3 lists
				independently a state for a new operation can be registered using
				`addunfinished()` in `state` module. The description of data needed
				to register an operation is stated under it.
				martinvonzUnsubmitted Not Done I'll drop the last sentence in flight since D6583 has landed. martinvonz: I'll drop the last sentence in flight since D6583 has landed.
				taapas1128AuthorUnsubmitted Done thanks! taapas1128: thanks!

				* `cmdutil.checkunfinished()` now includes detection for merge too.