Page MenuHomePhabricator

graft: moved abortgraft and readgraft to cmdutil
ClosedPublic

Authored by taapas1128 on Jul 6 2019, 2:48 PM.

Details

Summary

This patch moves abortgraft and readgraft to
cmdutil. Various callers are updated accordingly.

This is done because these serve as ulitlity functions
for command graft and so that new functions regarding
graft can be built from them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

taapas1128 created this revision.Jul 6 2019, 2:48 PM
pulkit added a subscriber: pulkit.Jul 8 2019, 11:51 AM

It will be nice to mention about our motivation to move code in the commit message.

mercurial/cmdutil.py
3350

We should drop _ perfix from names, both here and below.

3413

Unrequired newline at the end of file.

taapas1128 edited the summary of this revision. (Show Details)Jul 8 2019, 2:17 PM
taapas1128 updated this revision to Diff 15803.
taapas1128 marked 2 inline comments as done.Jul 8 2019, 2:21 PM
pulkit accepted this revision.Jul 8 2019, 5:09 PM
This revision is now accepted and ready to land.Jul 8 2019, 5:09 PM
This revision was automatically updated to reflect the committed changes.