| durin42 | |
| pulkit |
| hg-reviewers |
This patch adds the support for histedit in hg abort plan.
As seperate hgaborthistedit() function is created to handle
independent calls for abortion of histedit. This function is
then registered as abortfunc for state detection API.
hg abort in case of histedit also supports history-editing-backup
config option.
Results are shown as tests.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| hgext/histedit.py | ||
|---|---|---|
| 1922 | you need to set locks for the state too. Refer line 1685 in this file. | |
Looking closely, the backup value comes from reading ui.configbool('rewrite', 'backup-bundle') instead of a --no-backup flag. It means we can get rid of the --backup flag to hg abort as there exists no such flag for histedit.
Okay I will do that. So should I remove --no-backup flag altogether from this series of patches because none of the commands support --no-backup then.
Yes please remove. Also it will be nice if you fold all the abort related patches into one except D6608.
| tests/test-histedit-no-backup.t | ||
|---|---|---|
| 63 | Unwanted new line change, will drop it in flight. | |