Page MenuHomePhabricator

rust-utils: remove buggy assertion
ClosedPublic

Authored by Alphare on Jul 17 2019, 12:16 PM.

Details

Summary

While this assertion had good intentions, it broke existing behavior with a
nasty panic.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Jul 17 2019, 12:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Jul 18 2019, 9:45 AM
While this assertion had good intentions, it broke existing behavior with a
nasty panic.

So the hgignore parser doesn't handle \# correctly?

https://www.mercurial-scm.org/repo/hg-committed/file/5672bb73f61e/rust/hg-core/src/filepatterns.rs#l251