This is an archive of the discontinued Mercurial Phabricator instance.

rust-utils: remove buggy assertion
ClosedPublic

Authored by Alphare on Jul 17 2019, 12:16 PM.

Reviewers

None

Group Reviewers

hg-reviewers

Commits

Summary

While this assertion had good intentions, it broke existing behavior with a
nasty panic.

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision was not accepted when it landed; it landed in state Needs Review.

This revision was automatically updated to reflect the committed changes.

While this assertion had good intentions, it broke existing behavior with a
nasty panic.

So the hgignore parser doesn't handle \# correctly?

			Path	Packages
M			rust/hg-core/src/utils.rs (3 lines)

	/// b"I love writing tests!".to_vec()			/// b"I love writing tests!".to_vec()
	///);			///);
	///			///
	/// ```			/// ```
	pub fn replace_slice<T>(buf: &mut [T], from: &[T], to: &[T])			pub fn replace_slice<T>(buf: &mut [T], from: &[T], to: &[T])
	where			where
	T: Clone + PartialEq,			T: Clone + PartialEq,
	{			{
	assert_eq!(from.len(), to.len());			if buf.len() < from.len() \|\| from.len() != to.len() {
	if buf.len() < from.len() {
	return;			return;
	}			}
	for i in 0..=buf.len() - from.len() {			for i in 0..=buf.len() - from.len() {
	if buf[i..].starts_with(from) {			if buf[i..].starts_with(from) {
	buf[i..(i + from.len())].clone_from_slice(to);			buf[i..(i + from.len())].clone_from_slice(to);
	}			}
	}			}
	}			}