This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6658

py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines
ClosedPublic

Authored by durin42 on Jul 18 2019, 2:24 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGe19353715a64: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines
rHGeb27d9eee2cc: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines
Summary

I'm not clear why this behaves very slightly differently on Python 3,
but I'm also not concerned about it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jul 18 2019, 2:24 PM
martinvonz accepted this revision.Jul 21 2019, 10:24 AM
martinvonz added a subscriber: martinvonz.

Heh, I wrote a patch for this before I saw yours. The problem is that random.sample() (and other integer-based functions) changed, see https://bugs.python.org/issue27742.

This revision is now accepted and ready to land.Jul 21 2019, 10:24 AM
martinvonz added inline comments.Jul 21 2019, 8:24 PM
tests/test-setdiscovery.t
988

Fixing this in flight to be 187 in both places :)

martinvonz added inline comments.Jul 22 2019, 12:54 PM
tests/test-setdiscovery.t
988

But then the old commit was accepted, so the bad version is now public. I'll send a fix instead.

Revision Contents
Changeset List

PathPackages
Mtests/test-setdiscovery.t (6 lines)

Diff 15985

tests/test-setdiscovery.t

taking quick initial sample taking quick initial sample
searching: 2 queries searching: 2 queries
query 2; still undecided: 1080, sample size is: 100 query 2; still undecided: 1080, sample size is: 100
sampling from both directions sampling from both directions
searching: 3 queries searching: 3 queries
query 3; still undecided: 980, sample size is: 200 query 3; still undecided: 980, sample size is: 200
sampling from both directions sampling from both directions
searching: 4 queries searching: 4 queries
query 4; still undecided: 435, sample size is: 210 query 4; still undecided: 435, sample size is: 210 (no-py3 !)
query 4; still undecided: 430, sample size is: 210 (py3 !)
sampling from both directions sampling from both directions
searching: 5 queries searching: 5 queries
query 5; still undecided: 185, sample size is: 185 query 5; still undecided: 185, sample size is: 185 (no-py3 !)
query 5; still undecided: 187, sample size is: 185 (py3 !)
martinvonzUnsubmitted
Not Done

Fixing this in flight to be 187 in both places :)

martinvonz: Fixing this in flight to be 187 in both places :)
martinvonzUnsubmitted
Not Done

But then the old commit was accepted, so the bad version is now public. I'll send a fix instead.

martinvonz: But then the old commit was accepted, so the bad version is now public. I'll send a fix instead.
5 total queries in *.????s (glob) 5 total queries in *.????s (glob)
elapsed time: * seconds (glob) elapsed time: * seconds (glob)
heads summary: heads summary:
total common heads: 1 total common heads: 1
also local heads: 0 also local heads: 0
also remote heads: 0 also remote heads: 0
both: 0 both: 0
local heads: 260 local heads: 260