This is an archive of the discontinued Mercurial Phabricator instance.

Differential D667

changegroup: delete getlocalchangegroup
ClosedPublic

Authored by durham on Sep 10 2017, 10:06 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6097a616178d: changegroup: delete getlocalchangegroup
Summary

As part of reducing the number of changegroup creation APIs, let's go ahead and
delete this unused function. It appears to have been deprecated in the last
release anyway.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Sep 10 2017, 10:06 PM
indygreg accepted this revision.Sep 11 2017, 6:15 PM
This revision is now accepted and ready to land.Sep 11 2017, 6:15 PM
Closed by commit rHG6097a616178d: changegroup: delete getlocalchangegroup (authored by durham). · Explain WhySep 11 2017, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (5 lines)

Diff 1736

mercurial/changegroup.py

This is only implemented for local repos and reuses potentially This is only implemented for local repos and reuses potentially
precomputed sets in outgoing.""" precomputed sets in outgoing."""
if not outgoing.missing: if not outgoing.missing:
return None return None
return makechangegroup(repo, outgoing, version, source, return makechangegroup(repo, outgoing, version, source,
bundlecaps=bundlecaps) bundlecaps=bundlecaps)
def getlocalchangegroup(repo, *args, **kwargs):
repo.ui.deprecwarn('getlocalchangegroup is deprecated, use getchangegroup',
'4.3')
return getchangegroup(repo, *args, **kwargs)
def changegroup(repo, basenodes, source): def changegroup(repo, basenodes, source):
# to avoid a race we use changegroupsubset() (issue1320) # to avoid a race we use changegroupsubset() (issue1320)
outgoing = discovery.outgoing(repo, missingroots=basenodes, outgoing = discovery.outgoing(repo, missingroots=basenodes,
missingheads=repo.heads()) missingheads=repo.heads())
return makechangegroup(repo, outgoing, '01', source) return makechangegroup(repo, outgoing, '01', source)
def _addchangegroupfiles(repo, source, revmap, trp, expectedfiles, needfiles): def _addchangegroupfiles(repo, source, revmap, trp, expectedfiles, needfiles):
revisions = 0 revisions = 0