This is an archive of the discontinued Mercurial Phabricator instance.

Differential D671

changegroup: rename getsubsetraw to makestream
ClosedPublic

Authored by durham on Sep 10 2017, 10:07 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG92f1e2be8ab6: changegroup: rename getsubsetraw to makestream
Summary

Now that nothing uses getsubsetraw except makestream, let's move the
functionality into the makestream. This removes the last remaining excess
changegroup creation function, getsubsetraw.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Sep 10 2017, 10:07 PM
indygreg accepted this revision.Sep 11 2017, 6:11 PM
This revision is now accepted and ready to land.Sep 11 2017, 6:11 PM
Closed by commit rHG92f1e2be8ab6: changegroup: rename getsubsetraw to makestream (authored by durham). · Explain WhySep 11 2017, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (10 lines)

Diff 1740

mercurial/changegroup.py

def _changegroupinfo(repo, nodes, source): def _changegroupinfo(repo, nodes, source):
if repo.ui.verbose or source == 'bundle': if repo.ui.verbose or source == 'bundle':
repo.ui.status(_("%d changesets found\n") % len(nodes)) repo.ui.status(_("%d changesets found\n") % len(nodes))
if repo.ui.debugflag: if repo.ui.debugflag:
repo.ui.debug("list of changesets:\n") repo.ui.debug("list of changesets:\n")
for node in nodes: for node in nodes:
repo.ui.debug("%s\n" % hex(node)) repo.ui.debug("%s\n" % hex(node))
def makestream(repo, outgoing, version, source, fastpath=False,
bundlecaps=None):
bundler = getbundler(version, repo, bundlecaps=bundlecaps)
return getsubsetraw(repo, outgoing, bundler, source, fastpath=fastpath)
def makechangegroup(repo, outgoing, version, source, fastpath=False, def makechangegroup(repo, outgoing, version, source, fastpath=False,
bundlecaps=None): bundlecaps=None):
cgstream = makestream(repo, outgoing, version, source, cgstream = makestream(repo, outgoing, version, source,
fastpath=fastpath, bundlecaps=bundlecaps) fastpath=fastpath, bundlecaps=bundlecaps)
return getunbundler(version, util.chunkbuffer(cgstream), None, return getunbundler(version, util.chunkbuffer(cgstream), None,
{'clcount': len(outgoing.missing) }) {'clcount': len(outgoing.missing) })
def getsubsetraw(repo, outgoing, bundler, source, fastpath=False): def makestream(repo, outgoing, version, source, fastpath=False,
bundlecaps=None):
bundler = getbundler(version, repo, bundlecaps=bundlecaps)
repo = repo.unfiltered() repo = repo.unfiltered()
commonrevs = outgoing.common commonrevs = outgoing.common
csets = outgoing.missing csets = outgoing.missing
heads = outgoing.missingheads heads = outgoing.missingheads
# We go through the fast path if we get told to, or if all (unfiltered # We go through the fast path if we get told to, or if all (unfiltered
# heads have been requested (since we then know there all linkrevs will # heads have been requested (since we then know there all linkrevs will
# be pulled by the client). # be pulled by the client).
heads.sort() heads.sort()