This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6717

mypy: add a mypy.ini config file
Needs RevisionPublic

Authored by indygreg on Aug 4 2019, 3:52 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

Static analysis is good. Let's encourage its use by adding
a mypy.ini config file to the repo that has reasonable defaults.

With this file in place, mypy appears to "just work" out of
the box. It yields a ton of errors and warnings though. But
it's a start!

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 4 2019, 3:52 PM
pulkit added a subscriber: pulkit.Aug 7 2019, 6:20 PM

I am +1 on this. If I don't hear any objection on it until next week, I will queue it. Thanks for doing this work!

durin42 added a subscriber: durin42.Aug 14 2019, 3:23 PM

Did you run tests on this patch? IIRC there's a test that'll fail ;)

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM

Revision Contents
Changeset List

PathPackages
AMmypy.ini (29 lines)

Diff 16126

mypy.ini

  • This file was added.
# To run mypy against Mercurial, do something like the following:
#
# $ python3.7 -m pip install mypy
# $ python3.7 mypy
#
# Note: Mercurial's source tree has source files that may not parse
# on the version of Python being targeted. Currently released versions
# of mypy treat parse errors as fatal. To work around this, install
# a mypy with the change from https://github.com/python/mypy/pull/7286
# and uncomment the `ignore_parse_errors` line below.
[mypy]
files = hgext/**/*.py, hgdemandimport/**/*.py, mercurial/**/*.py
cache_dir = build/mypy-cache
# By default mypy targets the Python version it runs as. Mypy requires
# Python 3.5 to run.
python_version = 2.7
# Various functionality is optional. Suppress missing imports globally
# to cut down on noise.
ignore_missing_imports = True
# TODO enable once feature lands upstream
# ignore_parse_errors = True
# We don't control third party code. Don't error on it.
[mypy-mercurial.thirdparty.*]
ignore_errors = True