Page MenuHomePhabricator

branchmap: refresh all "heads" of the branchmap subsets
Needs RevisionPublic

Authored by spectral on Mon, Aug 5, 9:07 PM.

Details

Reviewers
durin42
marmoute
Group Reviewers
hg-reviewers
Summary

The comment about 'served' refreshing all the others only applies when served is
the head of the branchmap cache subsets. This was already no longer the case
(and is presumably why served.hidden was added) but the comment was not
adjusted. Currently, the "heads" of the branchmap cache subsets are the three
specified here: visible, visible-hidden, served.hidden.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Mon, Aug 5, 9:07 PM

Adding marmoute as explicit reviewer.

marmoute requested changes to this revision.Thu, Aug 8, 12:47 PM

It seems like we are not warming enought cache with the new scheme.

mercurial/localrepo.py
2204

We are no longer warming served explicitly If served and served.hidden are different this will be an issue (since served is much more used than served.hidden.

I would also add a XXX to the comment about visible-hidden to encourage people to investigate. This said. The same apply, we would need to warm both visible and visible.hidden explciitly.

mercurial/utils/repoviewutil.py
28

Oops, it seems like visible-hidden and served.hidden has inconsistent naming. Feel free to fix that along the way.

This revision now requires changes to proceed.Thu, Aug 8, 12:47 PM