This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6746

perf: don't pass experimental argument in config for older Mercurial versions
AbandonedPublic

Authored by navaneeth.suresh on Aug 20 2019, 10:30 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

This is a follow-up patch to a11fd395e83f. This patch makes older Mercurial
versions to not use experimental argument in config options.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Aug 20 2019, 10:33 AM
pulkit added inline comments.
contrib/perf.py
270

Can you add the commit hash and hg version (5.2 in this case) as comment due to which the compatibility is need?

navaneeth.suresh marked an inline comment as done.Aug 20 2019, 11:18 AM
navaneeth.suresh updated this revision to Diff 16271.
martinvonz added a subscriber: martinvonz.Aug 20 2019, 11:29 AM

When this patch is ready, could we fold this into a11fd395e83f? I have extensions.perf=contrib/perf.py in my config and it's pretty annoying to have any commit in the broken range checked out.

pulkit added a comment.Aug 20 2019, 11:38 AM
In D6746#99035, @martinvonz wrote:

When this patch is ready, could we fold this into a11fd395e83f? I have extensions.perf=contrib/perf.py in my config and it's pretty annoying to have any commit in the broken range checked out.

Folding this into a11fd395e83f.

pulkit accepted this revision.Aug 20 2019, 11:38 AM
This revision is now accepted and ready to land.Aug 20 2019, 11:38 AM
pulkit added a comment.Aug 20 2019, 12:03 PM

Folded https://www.mercurial-scm.org/repo/hg-committed/rev/9f2189b6bf2a. This can be closed now. Thanks for the quick fix.

navaneeth.suresh abandoned this revision.Aug 20 2019, 12:04 PM

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (24 lines)

Diff 16271

contrib/perf.py

default=mercurial.configitems.dynamicdefault, default=mercurial.configitems.dynamicdefault,
) )
configitem(b'perf', b'run-limits', configitem(b'perf', b'run-limits',
default=mercurial.configitems.dynamicdefault, default=mercurial.configitems.dynamicdefault,
experimental=True, experimental=True,
) )
except (ImportError, AttributeError): except (ImportError, AttributeError):
pass pass
except TypeError:
pulkitUnsubmitted
Done

Can you add the commit hash and hg version (5.2 in this case) as comment due to which the compatibility is need?

pulkit: Can you add the commit hash and hg version (5.2 in this case) as comment due to which the…
# compatibility fix for a11fd395e83f
# hg version: 5.2
configitem(b'perf', b'presleep',
default=mercurial.configitems.dynamicdefault,
)
configitem(b'perf', b'stub',
default=mercurial.configitems.dynamicdefault,
)
configitem(b'perf', b'parentscount',
default=mercurial.configitems.dynamicdefault,
)
configitem(b'perf', b'all-timing',
default=mercurial.configitems.dynamicdefault,
)
configitem(b'perf', b'pre-run',
default=mercurial.configitems.dynamicdefault,
)
configitem(b'perf', b'profile-benchmark',
default=mercurial.configitems.dynamicdefault,
)
configitem(b'perf', b'run-limits',
default=mercurial.configitems.dynamicdefault,
)
def getlen(ui): def getlen(ui):
if ui.configbool(b"perf", b"stub", False): if ui.configbool(b"perf", b"stub", False):
return lambda x: 1 return lambda x: 1
return len return len
class noop(object): class noop(object):
"""dummy context manager""" """dummy context manager"""