This is an archive of the discontinued Mercurial Phabricator instance.

Differential D675

rage: remove unused variable
ClosedPublic

Authored by ikostia on Sep 11 2017, 6:25 AM.
Tags
None
Subscribers
None

Details

Reviewers
stash
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGXbf097bb3369f: rage: remove unused variable
Summary

This makes test-check-pyflakes-hg.t complain, so let's fix it.

Test Plan
  • run this test, see it stop complaining.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

ikostia created this revision.Sep 11 2017, 6:25 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2017, 6:25 AM
stash accepted this revision.Sep 11 2017, 6:26 AM
This revision is now accepted and ready to land.Sep 11 2017, 6:26 AM
ryanmce accepted this revision.Sep 11 2017, 6:29 AM
Closed by commit rFBHGXbf097bb3369f: rage: remove unused variable (authored by ikostia). · Explain WhySep 12 2017, 11:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/rage.py (6 lines)

Diff 1709

hgext3rd/rage.py

try: try:
resp = conduit.call_conduit('paste.create', { resp = conduit.call_conduit('paste.create', {
'content': msg, 'content': msg,
'title': 'hg rage for %s' % _failsafe(lambda: repo.root), 'title': 'hg rage for %s' % _failsafe(lambda: repo.root),
'language': 'hgrage' 'language': 'hgrage'
}, timeout=timeout) }, timeout=timeout)
pasteurl = resp.get('uri') pasteurl = resp.get('uri')
except arcconfig.ArcConfigError as ex: except arcconfig.ArcConfigError:
ui.warn(_('arcconfig configuration problem.\n')) ui.warn(_('arcconfig configuration problem.\n'))
except conduit.ClientError as ex: except conduit.ClientError:
ui.warn(_('Error talking to phabricator.\n')) ui.warn(_('Error talking to phabricator.\n'))
except ValueError as ex: except ValueError:
ui.warn(_('Bad response from phabricator.\n')) ui.warn(_('Bad response from phabricator.\n'))
if pasteurl: if pasteurl:
if opts.get('oncall'): if opts.get('oncall'):
createtask(ui, repo, 'rage info: %s' % pasteurl) createtask(ui, repo, 'rage info: %s' % pasteurl)
else: else:
ui.write(_('Please post your problem and the following link at' ui.write(_('Please post your problem and the following link at'
' %s for help:\n%s\n') ' %s for help:\n%s\n')
% (ui.config('ui', 'supportcontact'), pasteurl)) % (ui.config('ui', 'supportcontact'), pasteurl))
else: else:
ui.warn(_('No paste was created.\n')) ui.warn(_('No paste was created.\n'))
fd, tmpname = tempfile.mkstemp(prefix='hg-rage-') fd, tmpname = tempfile.mkstemp(prefix='hg-rage-')
with os.fdopen(fd, r'w') as tmpfp: with os.fdopen(fd, r'w') as tmpfp:
tmpfp.write(msg) tmpfp.write(msg)
ui.warn(_('Saved contents to %s\n') % tmpname) ui.warn(_('Saved contents to %s\n') % tmpname)