Page MenuHomePhabricator

rustfilepatterns: refactor the pattern of removing a prefix from a &[u8]
ClosedPublic

Authored by valentin.gatienbaron on Aug 26 2019, 8:28 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kevincox accepted this revision.Aug 28 2019, 5:33 AM
kevincox added inline comments.
rust/hg-core/src/utils.rs
43

I have a small preference for drop_prefix.

43

Put a space in needle: &Self

85

Put a space in needle: &Self

valentin.gatienbaron marked 3 inline comments as done.Aug 28 2019, 7:45 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.