This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6790

tests: use positive revision numbers in test-strip-cross.t
ClosedPublic

Authored by martinvonz on Sep 7 2019, 2:37 AM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHGf78f7448a969: tests: use positive revision numbers in test-strip-cross.t

Summary

It took me a long time to realize that '-r -1' was pulling revision -1
because I didn't even notice the minus sign until I tried changing the
revision number. The order of arguments doesn't matter, so I changed
from decreasing order to increasing while at it.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

martinvonz created this revision.Sep 7 2019, 2:37 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptSep 7 2019, 2:37 AM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

martinvonz added a child revision: D6791: tests: don't log manifest-file in test-strip-cross.t.Sep 7 2019, 2:37 AM

pulkit accepted this revision.Sep 7 2019, 12:22 PM

This revision is now accepted and ready to land.Sep 7 2019, 12:22 PM

martinvonz added a commit: rHGf78f7448a969: tests: use positive revision numbers in test-strip-cross.t.Sep 9 2019, 12:08 PM

Closed by commit rHGf78f7448a969: tests: use positive revision numbers in test-strip-cross.t (authored by martinvonz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-strip-cross.t (2 lines)

Commit	Parents	Author	Summary	Date
678d690e557a	406bd21d363b	Martin von Zweigbergk		Dec 17 2018, 1:27 PM

Status	Author	Revision
Closed	martinvonz	D6795 strip: fix bug with treemanifests and unordered linkrevs
Closed	martinvonz	D6794 repair: extract a helper for generating all manifest revlogs
Closed	martinvonz	D6793 tests: show broken strip with treemanifests and unordered linkrevs
Closed	martinvonz	D6792 tests: split out manifest case from test-strip-cross.t
Closed	martinvonz	D6791 tests: don't log manifest-file in test-strip-cross.t
Closed	martinvonz	D6790 tests: use positive revision numbers in test-strip-cross.t

Diff 16395

tests/test-strip-cross.t

	$ commit '012 021' '102 201' '120 210'			$ commit '012 021' '102 201' '120 210'
	$ commit 'manifest-file'			$ commit 'manifest-file'
	$ commit '102 120' '012 210' '021 201'			$ commit '102 120' '012 210' '021 201'
	$ commit '201 210' '021 120' '012 102'			$ commit '201 210' '021 120' '012 102'
	$ HGUSER=another-user; export HGUSER			$ HGUSER=another-user; export HGUSER
	$ commit 'manifest-file'			$ commit 'manifest-file'
	$ commit '012' 'manifest-file'			$ commit '012' 'manifest-file'
	$ cd ..			$ cd ..
	$ hg clone -q -U -r -1 -r -2 -r -3 -r -4 -r -6 orig crossed			$ hg clone -q -U -r 4 -r 6 -r 7 -r 8 -r 9 orig crossed
	$ cd crossed			$ cd crossed
	$ hg debugindex --manifest			$ hg debugindex --manifest
	rev linkrev nodeid p1 p2			rev linkrev nodeid p1 p2
	0 0 6f105cbb914d 000000000000 000000000000			0 0 6f105cbb914d 000000000000 000000000000
	1 3 1b55917b3699 000000000000 000000000000			1 3 1b55917b3699 000000000000 000000000000
	2 1 8f3d04e263e5 000000000000 000000000000			2 1 8f3d04e263e5 000000000000 000000000000
	3 2 f0ef8726ac4f 000000000000 000000000000			3 2 f0ef8726ac4f 000000000000 000000000000
	4 4 0b76e38b4070 000000000000 000000000000			4 4 0b76e38b4070 000000000000 000000000000

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	16395		Sep 7 2019, 2:37 AM	★	★
Diff 2	16459	rHGf78f7448a96919dc74183066f51bdcb9139b1534	Dec 17 2018, 1:27 PM	★	★