This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6894

revlog: add the appropriate flag is sidedata are passed to `addrevision`
ClosedPublic

Authored by marmoute on Sep 27 2019, 12:17 PM.

Details

Reviewers
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG7bb5a2465501: revlog: add the appropriate flag is sidedata are passed to `addrevision`
Summary

If we need to store sidedata, we need the flag to be set and the associated
processing to be called.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (2 lines)

Diff 16766

mercurial/revlog.py

% self.indexfile) % self.indexfile)
if sidedata is None: if sidedata is None:
sidedata = {} sidedata = {}
elif not self.hassidedata: elif not self.hassidedata:
raise error.ProgrammingError( raise error.ProgrammingError(
_("trying to add sidedata to a revlog who don't support them") _("trying to add sidedata to a revlog who don't support them")
) )
else:
flags |= REVIDX_SIDEDATA
if flags: if flags:
node = node or self.hash(text, p1, p2) node = node or self.hash(text, p1, p2)
rawtext, validatehash = flagutil.processflagswrite(self, text, flags, rawtext, validatehash = flagutil.processflagswrite(self, text, flags,
sidedata=sidedata) sidedata=sidedata)
# If the flag processor modifies the revision data, ignore any provided # If the flag processor modifies the revision data, ignore any provided