| indygreg |
| hg-reviewers |
Both Python and C code are managed by formatters now, so relax this.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | contrib/check-code.py (2 lines) |
| pypats = [ | pypats = [ | ||||
| [ | [ | ||||
| # Ideally, these should be placed in "commonpypats" for | # Ideally, these should be placed in "commonpypats" for | ||||
| # consistency of coding rules in Mercurial source tree. | # consistency of coding rules in Mercurial source tree. | ||||
| # But on the other hand, these are not so seriously required for | # But on the other hand, these are not so seriously required for | ||||
| # python code fragments embedded in test scripts. Fixing test | # python code fragments embedded in test scripts. Fixing test | ||||
| # scripts for these patterns requires many changes, and has less | # scripts for these patterns requires many changes, and has less | ||||
| # profit than effort. | # profit than effort. | ||||
| (r'.{81}', "line too long"), | |||||
| (r'raise Exception', "don't raise generic exceptions"), | (r'raise Exception', "don't raise generic exceptions"), | ||||
| (r'[\s\(](open|file)\([^)]*\)\.read\(', | (r'[\s\(](open|file)\([^)]*\)\.read\(', | ||||
| "use util.readfile() instead"), | "use util.readfile() instead"), | ||||
| (r'[\s\(](open|file)\([^)]*\)\.write\(', | (r'[\s\(](open|file)\([^)]*\)\.write\(', | ||||
| "use util.writefile() instead"), | "use util.writefile() instead"), | ||||
| (r'^[\s\(]*(open(er)?|file)\([^)]*\)(?!\.close\(\))', | (r'^[\s\(]*(open(er)?|file)\([^)]*\)(?!\.close\(\))', | ||||
| "always assign an opened file to a variable, and close it afterwards"), | "always assign an opened file to a variable, and close it afterwards"), | ||||
| (r'[\s\(](open|file)\([^)]*\)\.(?!close\(\))', | (r'[\s\(](open|file)\([^)]*\)\.(?!close\(\))', | ||||
| [] | [] | ||||
| ] | ] | ||||
| cpats = [ | cpats = [ | ||||
| [ | [ | ||||
| (r'//', "don't use //-style comments"), | (r'//', "don't use //-style comments"), | ||||
| (r'\S\t', "don't use tabs except for indent"), | (r'\S\t', "don't use tabs except for indent"), | ||||
| (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"), | (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"), | ||||
| (r'.{81}', "line too long"), | |||||
| (r'(while|if|do|for)\(', "use space after while/if/do/for"), | (r'(while|if|do|for)\(', "use space after while/if/do/for"), | ||||
| (r'return\(', "return is not a function"), | (r'return\(', "return is not a function"), | ||||
| (r' ;', "no space before ;"), | (r' ;', "no space before ;"), | ||||
| (r'[^;] \)', "no space before )"), | (r'[^;] \)', "no space before )"), | ||||
| (r'[)][{]', "space between ) and {"), | (r'[)][{]', "space between ) and {"), | ||||
| (r'\w+\* \w+', "use int *foo, not int* foo"), | (r'\w+\* \w+', "use int *foo, not int* foo"), | ||||
| (r'\W\([^\)]+\) \w+', "use (int)foo, not (int) foo"), | (r'\W\([^\)]+\) \w+', "use (int)foo, not (int) foo"), | ||||
| (r'\w+ (\+\+|--)', "use foo++, not foo ++"), | (r'\w+ (\+\+|--)', "use foo++, not foo ++"), | ||||