This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6984

cvsps: switch a file open to a with statement
ClosedPublic

Authored by durin42 on Oct 5 2019, 1:45 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3b8a4587a456: cvsps: switch a file open to a with statement
Summary

For some reason this only showed up in check-code after running
black. Puzzling.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 5 2019, 1:45 PM
pulkit accepted this revision.Oct 5 2019, 1:58 PM
This revision is now accepted and ready to land.Oct 5 2019, 1:58 PM
durin42 added a commit: rHG3b8a4587a456: cvsps: switch a file open to a with statement.Oct 5 2019, 2:14 PM
Closed by commit rHG3b8a4587a456: cvsps: switch a file open to a with statement (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/convert/cvsps.py (3 lines)

Diff 16846

hgext/convert/cvsps.py

prefix = '' # leading path to strip of what we get from CVS prefix = '' # leading path to strip of what we get from CVS
if directory is None: if directory is None:
# Current working directory # Current working directory
# Get the real directory in the repository # Get the real directory in the repository
try: try:
prefix = open(os.path.join('CVS','Repository'), 'rb').read().strip() with open(os.path.join(b'CVS', b'Repository'), 'rb') as f:
prefix = f.read().strip()
directory = prefix directory = prefix
if prefix == ".": if prefix == ".":
prefix = "" prefix = ""
except IOError: except IOError:
raise logerror(_('not a CVS sandbox')) raise logerror(_('not a CVS sandbox'))
if prefix and not prefix.endswith(pycompat.ossep): if prefix and not prefix.endswith(pycompat.ossep):
prefix += pycompat.ossep prefix += pycompat.ossep