This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6978

contrib: black manages whitespace after Python keywords now
ClosedPublic

Authored by durin42 on Oct 5 2019, 11:01 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG28002d25eb54: contrib: black manages whitespace after Python keywords now

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 5 2019, 11:01 AM
indygreg accepted this revision.Oct 5 2019, 1:18 PM
This revision is now accepted and ready to land.Oct 5 2019, 1:18 PM

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (2 lines)

Diff 16873

contrib/check-code.py

if k not in ('print', 'exec')), if k not in ('print', 'exec')),
"Python keyword is not a function"), "Python keyword is not a function"),
# (r'class\s[A-Z][^\(]*\((?!Exception)', # (r'class\s[A-Z][^\(]*\((?!Exception)',
# "don't capitalize non-exception classes"), # "don't capitalize non-exception classes"),
# (r'in range\(', "use xrange"), # (r'in range\(', "use xrange"),
# (r'^\s*print\s+', "avoid using print in core and extensions"), # (r'^\s*print\s+', "avoid using print in core and extensions"),
(r'[\x80-\xff]', "non-ASCII character literal"), (r'[\x80-\xff]', "non-ASCII character literal"),
(r'("\')\.format\(', "str.format() has no bytes counterpart, use %"), (r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),
(r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),
"gratuitous whitespace after Python keyword"),
(r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"), (r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"),
# (r'\s\s=', "gratuitous whitespace before ="), # (r'\s\s=', "gratuitous whitespace before ="),
(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S', (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
"missing whitespace around operator"), "missing whitespace around operator"),
(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s', (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',
"missing whitespace around operator"), "missing whitespace around operator"),
(r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S', (r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
"missing whitespace around operator"), "missing whitespace around operator"),