This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6990

tests: allow xrange warning from perf.py
ClosedPublic

Authored by indygreg on Oct 5 2019, 4:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG094d0f4a8edd: tests: allow xrange warning from perf.py
Summary

The use of xrange in this file is acceptable.

We need to make the output optional - and not conditional on
the Python version - because pyflakes could be executed by any
Python version and pyflakes behaves differently depending on the
Python version.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 5 2019, 4:57 PM
indygreg retitled this revision from tests: filter xrange warning from perf.py to tests: allow xrange warning from perf.py.Oct 5 2019, 5:58 PM
indygreg edited the summary of this revision. (Show Details)
indygreg added a child revision: D6992: hgweb: use importlib.reload() if available.
indygreg updated this revision to Diff 16863.
indygreg set the repository for this revision to rHG Mercurial.Oct 6 2019, 10:39 AM
pulkit accepted this revision.Oct 6 2019, 10:40 AM
This revision is now accepted and ready to land.Oct 6 2019, 10:40 AM
indygreg added a commit: rHG094d0f4a8edd: tests: allow xrange warning from perf.py.Oct 6 2019, 11:05 AM
Closed by commit rHG094d0f4a8edd: tests: allow xrange warning from perf.py (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (1 line)

Diff 16890

tests/test-check-pyflakes.t

$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> -X mercurial/thirdparty/cbor \ > -X mercurial/thirdparty/cbor \
> -X mercurial/thirdparty/concurrent \ > -X mercurial/thirdparty/concurrent \
> -X mercurial/thirdparty/zope \ > -X mercurial/thirdparty/zope \
> 2>/dev/null \ > 2>/dev/null \
> | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*: undefined name 'xrange' (glob) (?)