This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6990

tests: allow xrange warning from perf.py
ClosedPublic

Authored by indygreg on Oct 5 2019, 4:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG094d0f4a8edd: tests: allow xrange warning from perf.py
Summary

The use of xrange in this file is acceptable.

We need to make the output optional - and not conditional on
the Python version - because pyflakes could be executed by any
Python version and pyflakes behaves differently depending on the
Python version.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 5 2019, 4:57 PM
indygreg retitled this revision from tests: filter xrange warning from perf.py to tests: allow xrange warning from perf.py.Oct 5 2019, 5:58 PM
indygreg edited the summary of this revision. (Show Details)
indygreg added a child revision: D6992: hgweb: use importlib.reload() if available.
indygreg updated this revision to Diff 16863.
indygreg set the repository for this revision to rHG Mercurial.Oct 6 2019, 10:39 AM
pulkit accepted this revision.Oct 6 2019, 10:40 AM
This revision is now accepted and ready to land.Oct 6 2019, 10:40 AM
indygreg added a commit: rHG094d0f4a8edd: tests: allow xrange warning from perf.py.Oct 6 2019, 11:05 AM
Closed by commit rHG094d0f4a8edd: tests: allow xrange warning from perf.py (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/filterpyflakes.py (3 lines)

Diff 16860

tests/filterpyflakes.py

for line in sys.stdin: for line in sys.stdin:
# We blacklist tests that are too noisy for us # We blacklist tests that are too noisy for us
pats = [ pats = [
r"undefined name 'WindowsError'", r"undefined name 'WindowsError'",
r"redefinition of unused '[^']+' from line", r"redefinition of unused '[^']+' from line",
# for cffi, allow re-exports from pure.* # for cffi, allow re-exports from pure.*
r"cffi/[^:]*:.*\bimport \*' used", r"cffi/[^:]*:.*\bimport \*' used",
r"cffi/[^:]*:.*\*' imported but unused", r"cffi/[^:]*:.*\*' imported but unused",
# This use of xrange is protected behind a conditional and
# is safe.
r"contrib/perf\.py:\d+: undefined name 'xrange'",
] ]
keep = True keep = True
for pat in pats: for pat in pats:
if re.search(pat, line): if re.search(pat, line):
keep = False keep = False
break # pattern matches break # pattern matches
if keep: if keep: