| hg-reviewers |
I only found a single user of this pattern, probably because we
use util.hasattr everywhere.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| mercurial/statprof.py | ||
|---|---|---|
| 171 | Should we switch to util.safehasattr() for consistency? | |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/__init__.py (4 lines) | |||
| M | mercurial/pycompat.py (1 line) | |||
| M | mercurial/statprof.py (2 lines) |
| if t.type == token.NEWLINE and futureimpline: | if t.type == token.NEWLINE and futureimpline: | ||||
| futureimpline = False | futureimpline = False | ||||
| if fullname == 'mercurial.pycompat': | if fullname == 'mercurial.pycompat': | ||||
| yield t | yield t | ||||
| continue | continue | ||||
| r, c = t.start | r, c = t.start | ||||
| l = ( | l = ( | ||||
| b'; from mercurial.pycompat import ' | b'; from mercurial.pycompat import ' | ||||
| b'delattr, getattr, hasattr\n' | b'delattr, getattr\n' | ||||
| ) | ) | ||||
| for u in tokenize.tokenize(io.BytesIO(l).readline): | for u in tokenize.tokenize(io.BytesIO(l).readline): | ||||
| if u.type in (tokenize.ENCODING, token.ENDMARKER): | if u.type in (tokenize.ENCODING, token.ENDMARKER): | ||||
| continue | continue | ||||
| yield u._replace( | yield u._replace( | ||||
| start=(r, c + u.start[1]), end=(r, c + u.end[1]) | start=(r, c + u.start[1]), end=(r, c + u.end[1]) | ||||
| ) | ) | ||||
| continue | continue | ||||
| # Emit unmodified token. | # Emit unmodified token. | ||||
| yield t | yield t | ||||
| # Header to add to bytecode files. This MUST be changed when | # Header to add to bytecode files. This MUST be changed when | ||||
| # ``replacetoken`` or any mechanism that changes semantics of module | # ``replacetoken`` or any mechanism that changes semantics of module | ||||
| # loading is changed. Otherwise cached bytecode may get loaded without | # loading is changed. Otherwise cached bytecode may get loaded without | ||||
| # the new transformation mechanisms applied. | # the new transformation mechanisms applied. | ||||
| BYTECODEHEADER = b'HG\x00\x0f' | BYTECODEHEADER = b'HG\x00\x10' | ||||
| class hgloader(importlib.machinery.SourceFileLoader): | class hgloader(importlib.machinery.SourceFileLoader): | ||||
| """Custom module loader that transforms source code. | """Custom module loader that transforms source code. | ||||
| When the source code is converted to a code object, we transform | When the source code is converted to a code object, we transform | ||||
| certain patterns to be Python 3 compatible. This allows us to write code | certain patterns to be Python 3 compatible. This allows us to write code | ||||
| that is natively Python 2 and compatible with Python 3 without | that is natively Python 2 and compatible with Python 3 without | ||||
| making the code excessively ugly. | making the code excessively ugly. | ||||
| bytestr = str | bytestr = str | ||||
| iterbytestr = iter | iterbytestr = iter | ||||
| maybebytestr = identity | maybebytestr = identity | ||||
| sysbytes = identity | sysbytes = identity | ||||
| sysstr = identity | sysstr = identity | ||||
| strurl = identity | strurl = identity | ||||
| bytesurl = identity | bytesurl = identity | ||||
| open = open | open = open | ||||
| hasattr = hasattr | |||||
| setattr = setattr | setattr = setattr | ||||
| # this can't be parsed on Python 3 | # this can't be parsed on Python 3 | ||||
| exec(b'def raisewithtb(exc, tb):\n' b' raise exc, None, tb\n') | exec(b'def raisewithtb(exc, tb):\n' b' raise exc, None, tb\n') | ||||
| def fsencode(filename): | def fsencode(filename): | ||||
| """ | """ | ||||
| Partial backport from os.py in Python 3, which only accepts bytes. | Partial backport from os.py in Python 3, which only accepts bytes. | ||||
Should we switch to util.safehasattr() for consistency?