This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7063

py3: fix test-bad-extension expectations for py35
ClosedPublic

Authored by Kwan on Oct 11 2019, 1:32 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG5ed1abd0ea26: py3: fix test-bad-extension expectations for py35
Summary

ModuleNotFoundError was introduced in 3.6, so the tests need to expect to see
ImportError with 3.5.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Kwan created this revision.Oct 11 2019, 1:32 PM

I think this is right but don't have py3.5 to check

Kwan added a comment.Oct 11 2019, 3:48 PM

Tested in a xenial VM with 3.5.2 and this does make the test pass.

indygreg accepted this revision.Oct 11 2019, 9:56 PM
This revision is now accepted and ready to land.Oct 11 2019, 9:56 PM
Kwan added a commit: rHG5ed1abd0ea26: py3: fix test-bad-extension expectations for py35.Oct 11 2019, 9:59 PM
Closed by commit rHG5ed1abd0ea26: py3: fix test-bad-extension expectations for py35 (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-bad-extension.t (27 lines)

Diff 17070

tests/test-bad-extension.t

$ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError|ModuleNotFound' $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError|ModuleNotFound'
*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
Traceback (most recent call last): Traceback (most recent call last):
Exception: bit bucket overflow Exception: bit bucket overflow
*** failed to import extension badext2: No module named *badext2* (glob) *** failed to import extension badext2: No module named *badext2* (glob)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named badext2 (no-py3 !) ImportError: No module named badext2 (no-py3 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py3 !) ImportError: No module named 'hgext.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py36 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3 !) ImportError: No module named 'hgext3rd.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py36 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
ModuleNotFoundError: No module named 'badext2' (py3 !) ImportError: No module named 'badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'badext2' (py36 !)
names of extensions failed to load can be accessed via extensions.notloaded() names of extensions failed to load can be accessed via extensions.notloaded()
$ cat <<EOF > showbadexts.py $ cat <<EOF > showbadexts.py
> from mercurial import commands, extensions, registrar > from mercurial import commands, extensions, registrar
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> @command(b'showbadexts', norepo=True) > @command(b'showbadexts', norepo=True)
YYYY/MM/DD HH:MM:SS (PID)> > baddocext extension loaded in * (glob) YYYY/MM/DD HH:MM:SS (PID)> > baddocext extension loaded in * (glob)
YYYY/MM/DD HH:MM:SS (PID)> - validating extension tables: baddocext YYYY/MM/DD HH:MM:SS (PID)> - validating extension tables: baddocext
YYYY/MM/DD HH:MM:SS (PID)> - invoking registered callbacks: baddocext YYYY/MM/DD HH:MM:SS (PID)> - invoking registered callbacks: baddocext
YYYY/MM/DD HH:MM:SS (PID)> > callbacks completed in * (glob) YYYY/MM/DD HH:MM:SS (PID)> > callbacks completed in * (glob)
YYYY/MM/DD HH:MM:SS (PID)> - loading extension: badext2 YYYY/MM/DD HH:MM:SS (PID)> - loading extension: badext2
YYYY/MM/DD HH:MM:SS (PID)> - could not import hgext.badext2 (No module named *badext2*): trying hgext3rd.badext2 (glob) YYYY/MM/DD HH:MM:SS (PID)> - could not import hgext.badext2 (No module named *badext2*): trying hgext3rd.badext2 (glob)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named badext2 (no-py3 !) ImportError: No module named badext2 (no-py3 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py3 !) ImportError: No module named 'hgext.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py36 !)
YYYY/MM/DD HH:MM:SS (PID)> - could not import hgext3rd.badext2 (No module named *badext2*): trying badext2 (glob) YYYY/MM/DD HH:MM:SS (PID)> - could not import hgext3rd.badext2 (No module named *badext2*): trying badext2 (glob)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named badext2 (no-py3 !) ImportError: No module named badext2 (no-py3 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py3 !) ImportError: No module named 'hgext.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py36 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3 !) ImportError: No module named 'hgext3rd.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py36 !)
*** failed to import extension badext2: No module named *badext2* (glob) *** failed to import extension badext2: No module named *badext2* (glob)
Traceback (most recent call last): Traceback (most recent call last):
ModuleNotFoundError: No module named 'hgext.badext2' (py3 !) ImportError: No module named 'hgext.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext.badext2' (py36 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3 !) ImportError: No module named 'hgext3rd.badext2' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext3rd.badext2' (py36 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
ModuleNotFoundError: No module named 'badext2' (py3 !) ModuleNotFoundError: No module named 'badext2' (py36 !)
ImportError: No module named 'badext2' (py3 no-py36 !)
ImportError: No module named badext2 (no-py3 !) ImportError: No module named badext2 (no-py3 !)
YYYY/MM/DD HH:MM:SS (PID)> > loaded 2 extensions, total time * (glob) YYYY/MM/DD HH:MM:SS (PID)> > loaded 2 extensions, total time * (glob)
YYYY/MM/DD HH:MM:SS (PID)> - loading configtable attributes YYYY/MM/DD HH:MM:SS (PID)> - loading configtable attributes
YYYY/MM/DD HH:MM:SS (PID)> - executing uisetup hooks YYYY/MM/DD HH:MM:SS (PID)> - executing uisetup hooks
YYYY/MM/DD HH:MM:SS (PID)> - running uisetup for gpg YYYY/MM/DD HH:MM:SS (PID)> - running uisetup for gpg
YYYY/MM/DD HH:MM:SS (PID)> > uisetup for gpg took * (glob) YYYY/MM/DD HH:MM:SS (PID)> > uisetup for gpg took * (glob)
YYYY/MM/DD HH:MM:SS (PID)> - running uisetup for baddocext YYYY/MM/DD HH:MM:SS (PID)> - running uisetup for baddocext
YYYY/MM/DD HH:MM:SS (PID)> > uisetup for baddocext took * (glob) YYYY/MM/DD HH:MM:SS (PID)> > uisetup for baddocext took * (glob)