Page MenuHomePhabricator

fix: fix registration of config item defaults
ClosedPublic

Authored by martinvonz on Oct 14 2019, 2:39 AM.

Details

Summary

Before this patch, because of the "(:<name>)?", all registered
patterns would match and the default value would not be the one we
thought we had registered (maybe it just took the default value for
the first match?). This didn't matter because we didn't care about the
default value; we used our own, intended default value in getfixers()
anyway.

We also have to look up each config item individually in order to not
get developer warnings.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 14 2019, 2:39 AM
pulkit accepted this revision.Oct 14 2019, 12:42 PM
This revision is now accepted and ready to land.Oct 14 2019, 12:42 PM
This revision was automatically updated to reflect the committed changes.