This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7083

fix: don't pass in default value when looking up config
ClosedPublic

Authored by martinvonz on Oct 14 2019, 2:39 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf4c1fd6addd5: fix: don't pass in default value when looking up config
Summary

The defaults are now registered correctly so we don't need to pass in
the default value when we look up a config value.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 14 2019, 2:39 AM
pulkit accepted this revision.Oct 14 2019, 12:42 PM
This revision is now accepted and ready to land.Oct 14 2019, 12:42 PM

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (4 lines)

Diff 17141

hgext/fix.py

"""Returns a map of configured fixer tools indexed by their names """Returns a map of configured fixer tools indexed by their names
Each value is a Fixer object with methods that implement the behavior of the Each value is a Fixer object with methods that implement the behavior of the
fixer's config suboptions. Does not validate the config values. fixer's config suboptions. Does not validate the config values.
""" """
fixers = {} fixers = {}
for name in fixernames(ui): for name in fixernames(ui):
fixers[name] = Fixer() fixers[name] = Fixer()
for key, default in FIXER_ATTRS.items(): for key in FIXER_ATTRS:
setattr( setattr(
fixers[name], fixers[name],
pycompat.sysstr(b'_' + key), pycompat.sysstr(b'_' + key),
ui.config(b'fix', name + b':' + key, default), ui.config(b'fix', name + b':' + key),
) )
fixers[name]._priority = int(fixers[name]._priority) fixers[name]._priority = int(fixers[name]._priority)
fixers[name]._metadata = stringutil.parsebool(fixers[name]._metadata) fixers[name]._metadata = stringutil.parsebool(fixers[name]._metadata)
fixers[name]._skipclean = stringutil.parsebool(fixers[name]._skipclean) fixers[name]._skipclean = stringutil.parsebool(fixers[name]._skipclean)
fixers[name]._enabled = stringutil.parsebool(fixers[name]._enabled) fixers[name]._enabled = stringutil.parsebool(fixers[name]._enabled)
# Don't use a fixer if it has no pattern configured. It would be # Don't use a fixer if it has no pattern configured. It would be
# dangerous to let it affect all files. It would be pointless to let it # dangerous to let it affect all files. It would be pointless to let it
# affect no files. There is no reasonable subset of files to use as the # affect no files. There is no reasonable subset of files to use as the