This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7107

rust-cross-platform: remove `unimplemented!` to get compile-time errors instead
ClosedPublic

Authored by Alphare on Oct 15 2019, 10:42 AM.

Details

Reviewers
kevincox
pulkit
Group Reviewers
hg-reviewers
Commits
rHG98d996a138de: rust-cross-platform: remove `unimplemented!` to get compile-time errors
rHG60ee5842f181: rust-cross-platform: remove `unimplemented!` to get compile-time errors
rHG3f21d1c1bba5: rust-cross-platform: remove `unimplemented!` to get compile-time errors
Summary

We should get a compile-time error that there is missing functionality for the
targeted platform instead of the program breaking at runtime.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 17219

rust/hg-core/src/utils/files.rs

pub fn get_path_from_bytes(bytes: &[u8]) -> &Path { pub fn get_path_from_bytes(bytes: &[u8]) -> &Path {
let os_str; let os_str;
#[cfg(unix)] #[cfg(unix)]
{ {
use std::os::unix::ffi::OsStrExt; use std::os::unix::ffi::OsStrExt;
os_str = std::ffi::OsStr::from_bytes(bytes); os_str = std::ffi::OsStr::from_bytes(bytes);
} }
#[cfg(windows)] // TODO Handle other platforms
{ // TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
// TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
// Perhaps, the return type would have to be Result<PathBuf>. // Perhaps, the return type would have to be Result<PathBuf>.
unimplemented!()
}
Path::new(os_str) Path::new(os_str)
} }
/// An iterator over repository path yielding itself and its ancestors. /// An iterator over repository path yielding itself and its ancestors.
#[derive(Copy, Clone, Debug)] #[derive(Copy, Clone, Debug)]
pub struct Ancestors<'a> { pub struct Ancestors<'a> {
next: Option<&'a HgPath>, next: Option<&'a HgPath>,

rust/hg-core/src/utils/hg_path.rs

) -> Result<OsString, HgPathError> { ) -> Result<OsString, HgPathError> {
hg_path.as_ref().check_state()?; hg_path.as_ref().check_state()?;
let os_str; let os_str;
#[cfg(unix)] #[cfg(unix)]
{ {
use std::os::unix::ffi::OsStrExt; use std::os::unix::ffi::OsStrExt;
os_str = std::ffi::OsStr::from_bytes(&hg_path.as_ref().as_bytes()); os_str = std::ffi::OsStr::from_bytes(&hg_path.as_ref().as_bytes());
} }
#[cfg(windows)] // TODO Handle other platforms
{ // TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
// TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
unimplemented!();
}
Ok(os_str.to_os_string()) Ok(os_str.to_os_string())
} }
pub fn hg_path_to_path_buf<P: AsRef<HgPath>>( pub fn hg_path_to_path_buf<P: AsRef<HgPath>>(
hg_path: P, hg_path: P,
) -> Result<PathBuf, HgPathError> { ) -> Result<PathBuf, HgPathError> {
Ok(Path::new(&hg_path_to_os_string(hg_path)?).to_path_buf()) Ok(Path::new(&hg_path_to_os_string(hg_path)?).to_path_buf())
} }
pub fn os_string_to_hg_path_buf<S: AsRef<OsStr>>( pub fn os_string_to_hg_path_buf<S: AsRef<OsStr>>(
os_string: S, os_string: S,
) -> Result<HgPathBuf, HgPathError> { ) -> Result<HgPathBuf, HgPathError> {
let buf; let buf;
#[cfg(unix)] #[cfg(unix)]
{ {
use std::os::unix::ffi::OsStrExt; use std::os::unix::ffi::OsStrExt;
buf = HgPathBuf::from_bytes(&os_string.as_ref().as_bytes()); buf = HgPathBuf::from_bytes(&os_string.as_ref().as_bytes());
} }
#[cfg(windows)] // TODO Handle other platforms
{
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding). // TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
unimplemented!();
}
buf.check_state()?; buf.check_state()?;
Ok(buf) Ok(buf)
} }
pub fn path_to_hg_path_buf<P: AsRef<Path>>( pub fn path_to_hg_path_buf<P: AsRef<Path>>(
path: P, path: P,
) -> Result<HgPathBuf, HgPathError> { ) -> Result<HgPathBuf, HgPathError> {
let buf; let buf;
let os_str = path.as_ref().as_os_str(); let os_str = path.as_ref().as_os_str();
#[cfg(unix)] #[cfg(unix)]
{ {
use std::os::unix::ffi::OsStrExt; use std::os::unix::ffi::OsStrExt;
buf = HgPathBuf::from_bytes(&os_str.as_bytes()); buf = HgPathBuf::from_bytes(&os_str.as_bytes());
} }
#[cfg(windows)] // TODO Handle other platforms
{
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding). // TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
unimplemented!();
}
buf.check_state()?; buf.check_state()?;
Ok(buf) Ok(buf)
} }
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;