This is an archive of the discontinued Mercurial Phabricator instance.

automation: schedule an EC2Launch run on next boot
ClosedPublic

Authored by indygreg on Oct 16 2019, 12:17 AM.

Details

Summary

Without this, launching EC2 instances constructed from the AMI
won't go through the normal EC2 instance launch machinery. This
missing machinery does important things like set up network
routes to use the instance metadata service and process any
UserData.

Since EC2Launch now runs on subsequent boots and UserData is
processed, we needed to make setting of UserData conditional
on bootstrapping mode.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 16 2019, 12:17 AM
pulkit accepted this revision.Oct 16 2019, 9:45 AM
This revision is now accepted and ready to land.Oct 16 2019, 9:45 AM
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
contrib/automation/hgautomation/aws.py
1128

black wants this line to be wrapped. I'll fix that in flight.

pulkit added inline comments.Oct 16 2019, 12:32 PM
contrib/automation/hgautomation/aws.py
1128

I should install black, I was waiting for Augie's fix to land to prevent doing some extra work.